Add Tibetan Extended Wylie combiner #1427
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Layout added in futo-org/futo-keyboard-layouts#202 |
abb128
reviewed
Aug 27, 2025
build.gradle
Outdated
| androidTestImplementation 'androidx.test.uiautomator:uiautomator:2.2.0' | ||
| androidTestImplementation 'androidx.annotation:annotation:1.0.0' | ||
|
|
||
| implementation 'io.bdrc.ewtsconverter:ewts-converter:1.6.0' |
There was a problem hiding this comment.
The library is only two Java files(?), I think I prefer the code to be vendored rather than adding a maven dependency
There was a problem hiding this comment.
Done, please check the code
abb128
reviewed
Aug 29, 2025
| package org.futo.inputmethod.event.combiners.wylie; | ||
|
|
||
| public class EwtsConverter { | ||
| } |
There was a problem hiding this comment.
I think you might have left it blank accidentally
There was a problem hiding this comment.
Also make sure you preserve their license notice since it's required for Apache https://github.com/buda-base/ewts-converter/blob/c1a6d3f6a5f32f32952f85afbe3610e852e96423/src/main/java/io/bdrc/ewtsconverter/EwtsConverter.java#L1-L19
There was a problem hiding this comment.
Sorry, I committed all changes now
|
Thanks! |
abb128
pushed a commit
that referenced
this pull request
Oct 3, 2025
Signed-off-by: Aleksandras Kostarevas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When paired with an appropriate layout, this would allow the input of Tibetan script using the Extended Wylie transliteration system. Uses the ewts-converter library (Apache-2.0 license).
wylie_demo.mp4