Performance improvement by reviewing ConstParamMap generation method for master #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#359
When setting ConstParamMap in ExecutionContext, we had been repackaging it into ConcurrentHashMap each time due to remnants of past implementations, but since it does not change, we decided to use the Map generated at initialization as is.
As a result, in the case of a ConstParamMap with 5,000 elements, 100,000 SQL issuances improved from 15 seconds to 0.03 seconds.
ExecutionContextにConstParamMapを設定する際、過去の実装の名残で都度ConcurrentHashMapに詰めなおしていたが、変更されないので初期化時に生成したMapをそのまま利用するようした。
これにより、5,000の要素を持つConstParamMapの場合、10万回のSQL発行が15秒→0.03秒に向上した。