fixed opening files with unicode chars#6
Open
suvit wants to merge 9 commits intofuturecolors:masterfrom
Open
Conversation
update gitignore
Member
|
Can you please add a test that fails before your commit and passes after? |
Author
|
no problem, but it takes some time |
added templates that breaks the tests added test
added templates that breaks the tests added test
more pep8
Author
|
Thanks @dgladkov for patch. Now Tests passes. |
Member
|
Hopefully I will incorporate your fix this week or so. Thnx. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed opening files with unicode chars in it and update gitignore