fix: accept unterminated block comments at EOF in scanner#232
Merged
VladimirMakaev merged 1 commit intofwcd:mainfrom Feb 19, 2026
Merged
Conversation
The scanner previously rejected unterminated /* comments at EOF, causing tree-sitter to parse the comment delimiters as operators (multiplicative_expression, spread_expression). This matches JetBrains PSI behavior which recognizes unclosed /* as a BLOCK_COMMENT token. Fixes 4 cross-validation fixtures (BlockCommentAtBeginningOfFile 1-4), improving match rate from 97/124 (78.2%) to 101/126 (80.2%).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/*comments at EOF as validmultiline_commenttokens, matching JetBrains PSI behavior/*as multiplication/spread operatorslexer->eof(lexer)guard so'\0'is only treated as EOF when it truly isImpact
Test plan
npm test— all 239 tests passnpm run cross-validate— 101/126 match ratenpx tree-sitter parseon all 4 BlockComment fixtures — clean parse trees