refactor(gsplat): factor common camera/projection helpers#1
Open
fwilliams wants to merge 28 commits intofw/rasterize_3dfrom
Open
refactor(gsplat): factor common camera/projection helpers#1fwilliams wants to merge 28 commits intofw/rasterize_3dfrom
fwilliams wants to merge 28 commits intofw/rasterize_3dfrom
Conversation
Signed-off-by: Francis Williams <francis@fwilliams.info>
Signed-off-by: Francis Williams <francis@fwilliams.info>
Signed-off-by: Francis Williams <francis@fwilliams.info>
Signed-off-by: Francis Williams <francis@fwilliams.info>
Signed-off-by: Francis Williams <francis@fwilliams.info>
Signed-off-by: Francis Williams <francis@fwilliams.info>
Signed-off-by: Francis Williams <francis@fwilliams.info>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Francis Williams <fwilliams@users.noreply.github.com>
Signed-off-by: Francis Williams <francis@fwilliams.info>
Signed-off-by: Francis Williams <francis@fwilliams.info>
Signed-off-by: Francis Williams <francis@fwilliams.info>
Signed-off-by: Francis Williams <francis@fwilliams.info>
Signed-off-by: Francis Williams <francis@fwilliams.info>
Extract shared helpers for camera matrices/intrinsics, rolling-shutter time, projection utilities, and optional raster inputs; refactor kernels to use them for readability without changing behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
fwilliams
force-pushed
the
fw/rasterize_3d
branch
2 times, most recently
from
46d4cde to
81ca796
Compare
fwilliams
force-pushed
the
fw/rasterize_3d
branch
2 times, most recently
from
e179d6f to
11f8d8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- Refactor gsplat projection/rasterization code to reuse common helpers (camera matrices, intrinsics, rolling shutter time, conic packing, optional inputs).\n- No intended algorithmic changes; readability/maintainability improvement only.\n\n## Why\n- Keeps the main rasterize-from-world/UT work focused, while landing mechanical cleanup separately.\n\n## Test plan\n- Build + \Usage
ctest [options]\n- Run key Python tests (Gaussian splat + rasterize-from-world)\n
Made with Cursor