chore: migrate soap api orgs to rest api

[Hrishabh17]

No description provided.

[coderabbitai]

📝 Walkthrough

Walkthrough

A new helper validate_rest_api_connection(workspace_id: int) -> None was added in apps/sage_intacct/helpers.py. It checks REST API connectivity by instantiating SageIntacctRestConnector, attempts a call to connection.locations.count(), and on success marks the workspace as migrated in FeatureConfig and triggers sync_dimensions. Calls to this validator were added at the start of initiate_import_to_fyle and inside check_interval_and_sync_dimension. BRAND_ID was introduced in pipeline env for the API service and imports were consolidated.

Poem

🔌 A tiny check before the sync takes flight,
Connections probed in the dim morning light,
Flags flipped true, dimensions begin to run,
A whisper of REST and a job smoothly done,
🚀 Code and data waltz until the day is bright.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	No pull request description was provided, missing required sections for context and motivation.	Add a description following the template with explanation of the migration approach and ClickUp link for tracking.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: migrating SOAP API organizations to REST API by adding validation and configuration for REST API connectivity.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
apps
exceptions.py	47	11	77%	27, 33, 39–44, 50, 56–61, 67, 73, 79–80
apps/fyle
actions.py	124	7	94%	214, 263, 319–323
constants.py	1	0	100%
helpers.py	235	14	94%	50–57, 66, 376, 470, 477–480, 483–484
models.py	338	21	94%	315–317, 321–323, 327–329, 333–335, 339–341, 345–347, 408, 530–551, 574, 591
queue.py	50	0	100%
serializers.py	41	0	100%
signals.py	35	6	83%	22, 55–56, 69–71
tasks.py	546	87	84%	132, 143–144, 147–148, 151–152, 174–175, 231–251, 263–268, 311–314, 339–343, 353–361, 400–410, 525–585, 906–910, 1048, 1059–1060, 1085–1086
views.py	172	15	91%	84–91, 145, 245–246, 290–291, 316–320, 413–417
apps/internal
actions.py	39	2	95%	31–32
helpers.py	36	13	64%	18–35
serializers.py	30	0	100%
tasks.py	92	32	65%	35–39, 66–71, 116, 128–179
views.py	83	1	99%	39
apps/internal/services
e2e_setup.py	59	0	100%
fixture_factory.py	59	3	95%	218–220
apps/mappings
constants.py	2	0	100%
exceptions.py	71	6	92%	69–71, 79–81
helpers.py	86	2	98%	93, 163
models.py	50	0	100%
schedules.py	15	0	100%
serializers.py	10	0	100%
signals.py	111	14	87%	90–92, 127, 179–184, 190–194, 200–203, 209–210
tasks.py	179	29	84%	118–119, 142–143, 146, 210–227, 255, 258, 261, 267, 270, 276, 316–318, 329, 407
utils.py	34	0	100%
views.py	46	4	91%	34–35, 114–115
apps/sage_intacct
actions.py	29	4	86%	21–22, 49–50
connector.py	847	19	98%	142, 318, 330, 336, 412, 1489, 1788, 1916–1917, 1984–1985, 2021–2022, 2052–2053, 2120–2121, 2156–2157
dependent_fields.py	290	42	86%	345, 381–384, 413–422, 424–425, 427–429, 431–432, 434–435, 437–438, 442–444, 488, 508, 548–550, 596–598, 646–652, 656–657
enums.py	25	0	100%
helpers.py	68	6	91%	58, 96, 151, 155–160
models.py	988	67	93%	78–79, 264–275, 405, 412, 456, 477–494, 567, 579, 629, 635, 670, 720–722, 736–749, 760, 796, 848–849, 949, 990, 1219, 1314–1317, 1361, 1363, 1455, 1559–1602, 1700, 1727, 1838, 2213–2215, 2277
queue.py	171	16	91%	45, 53, 58, 105, 130–133, 173, 187, 205–208, 243, 267–270, 305, 330–333
serializers.py	35	0	100%
tasks.py	1433	144	90%	105, 119, 152, 188–189, 193–196, 198, 201, 251, 286–287, 407–408, 414, 417, 460–461, 502–507, 572, 578, 586, 765–766, 786–789, 860–861, 884, 899, 904, 909, 916, 922, 925–927, 930–933, 936–938, 966, 1019–1020, 1101–1102, 1106, 1127, 1161, 1261–1262, 1338–1339, 1341, 1496–1497, 1586–1587, 1590, 1611, 1626, 1632, 1638, 1645, 1651, 1654–1656, 1659–1662, 1665–1667, 1694, 1839, 1851–1860, 1902, 1905–1910, 1913–1917, 2086–2090, 2189–2190, 2396–2406, 2409, 2418–2423, 2457–2459, 2493–2496, 2564–2568, 2577, 2666–2671, 2684, 2699, 2714
utils.py	910	33	96%	742–746, 891, 1210, 1226–1232, 1241–1242, 1983–1987, 2030–2034, 2077–2081, 2125–2129, 2199–2203, 2224, 2233, 2242, 2251–2252
views.py	145	33	77%	127–129, 134–135, 141–142, 185–188, 258–288, 299–314, 327–331
apps/sage_intacct/errors
errors.py	2	0	100%
helpers.py	47	1	98%	80
apps/sage_intacct/exports
ap_payments.py	13	0	100%
bills.py	28	0	100%
charge_card_transactions.py	22	0	100%
expense_reports.py	28	0	100%
helpers.py	56	2	96%	68, 141
journal_entries.py	76	8	89%	177–180, 316–319
reimbursements.py	13	0	100%
apps/tasks
models.py	70	0	100%
serializers.py	6	0	100%
views.py	37	0	100%
apps/users
helpers.py	12	0	100%
models.py	53	0	100%
views.py	17	0	100%
apps/workspaces
actions.py	46	9	80%	65, 84–85, 103, 122–133, 147
enums.py	92	0	100%
helpers.py	8	0	100%
models.py	176	0	100%
permissions.py	34	9	74%	33, 59–67
serializers.py	43	1	98%	54
signals.py	31	0	100%
system_comments.py	19	0	100%
tasks.py	175	9	95%	53–59, 187–194, 235, 267–268, 379
utils.py	9	0	100%
views.py	329	9	97%	110–112, 139–142, 702–703
apps/workspaces/apis/advanced_settings
serializers.py	80	3	96%	260, 263, 266
triggers.py	10	0	100%
views.py	11	0	100%
apps/workspaces/apis/errors
serializers.py	20	0	100%
views.py	15	0	100%
apps/workspaces/apis/export_settings
helpers.py	73	0	100%
serializers.py	103	3	97%	267, 270, 273
triggers.py	56	2	96%	33–34
views.py	11	0	100%
apps/workspaces/apis/import_settings
serializers.py	141	18	87%	232–238, 243–249, 257–265, 283, 286, 314, 317–318, 326
triggers.py	47	1	98%	31
views.py	33	0	100%
fyle_integrations_imports
dataclasses.py	31	0	100%
models.py	23	0	100%
queues.py	34	5	85%	24, 99, 136, 148–149
signals.py	10	0	100%
tasks.py	127	81	36%	69–111, 120–126, 139–208, 212–227, 252–255, 257, 259, 264
fyle_integrations_imports/modules
base.py	188	10	95%	75, 91–92, 95, 126, 230–231, 237–238, 351
categories.py	177	33	81%	80, 96, 99–100, 103–104, 272–273, 283, 296, 298, 342, 351–355, 364–410
cost_centers.py	96	12	88%	132–133, 152–153, 162, 178, 180, 226, 235–239
expense_custom_fields.py	121	7	94%	83–88, 247, 263, 265, 294
merchants.py	106	25	76%	80–83, 111–129, 155–162, 179–180, 190, 203, 205, 235, 238–242
projects.py	123	40	67%	88, 103–168, 188–189, 199, 223, 270, 284–288
tax_groups.py	18	0	100%
webhook_attributes.py	130	6	95%	98, 100–102, 213–214
workers
actions.py	21	0	100%
helpers.py	43	0	100%
worker.py	56	5	91%	44–45, 77–78, 125
TOTAL	10878	930	91%

Tests	Skipped	Failures	Errors	Time
830	0 💤	0 ❌	0 🔥	1m 8s ⏱️

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
apps
exceptions.py	47	11	77%	27, 33, 39–44, 50, 56–61, 67, 73, 79–80
apps/fyle
actions.py	124	7	94%	214, 263, 319–323
constants.py	1	0	100%
helpers.py	235	14	94%	50–57, 66, 376, 470, 477–480, 483–484
models.py	338	21	94%	315–317, 321–323, 327–329, 333–335, 339–341, 345–347, 408, 530–551, 574, 591
queue.py	50	0	100%
serializers.py	41	0	100%
signals.py	35	6	83%	22, 55–56, 69–71
tasks.py	546	87	84%	132, 143–144, 147–148, 151–152, 174–175, 231–251, 263–268, 311–314, 339–343, 353–361, 400–410, 525–585, 906–910, 1048, 1059–1060, 1085–1086
views.py	172	15	91%	84–91, 145, 245–246, 290–291, 316–320, 413–417
apps/internal
actions.py	39	2	95%	31–32
helpers.py	36	13	64%	18–35
serializers.py	30	0	100%
tasks.py	92	32	65%	35–39, 66–71, 116, 128–179
views.py	83	1	99%	39
apps/internal/services
e2e_setup.py	59	0	100%
fixture_factory.py	59	3	95%	218–220
apps/mappings
constants.py	2	0	100%
exceptions.py	71	6	92%	69–71, 79–81
helpers.py	86	2	98%	93, 163
models.py	50	0	100%
schedules.py	15	0	100%
serializers.py	10	0	100%
signals.py	111	14	87%	90–92, 127, 179–184, 190–194, 200–203, 209–210
tasks.py	179	29	84%	118–119, 142–143, 146, 210–227, 255, 258, 261, 267, 270, 276, 316–318, 329, 407
utils.py	34	0	100%
views.py	46	4	91%	34–35, 114–115
apps/sage_intacct
actions.py	29	4	86%	21–22, 49–50
connector.py	847	19	98%	142, 318, 330, 336, 412, 1489, 1788, 1916–1917, 1984–1985, 2021–2022, 2052–2053, 2120–2121, 2156–2157
dependent_fields.py	290	42	86%	345, 381–384, 413–422, 424–425, 427–429, 431–432, 434–435, 437–438, 442–444, 488, 508, 548–550, 596–598, 646–652, 656–657
enums.py	25	0	100%
helpers.py	68	6	91%	58, 96, 151, 155–160
models.py	988	67	93%	78–79, 264–275, 405, 412, 456, 477–494, 567, 579, 629, 635, 670, 720–722, 736–749, 760, 796, 848–849, 949, 990, 1219, 1314–1317, 1361, 1363, 1455, 1559–1602, 1700, 1727, 1838, 2213–2215, 2277
queue.py	171	16	91%	45, 53, 58, 105, 130–133, 173, 187, 205–208, 243, 267–270, 305, 330–333
serializers.py	35	0	100%
tasks.py	1433	144	90%	105, 119, 152, 188–189, 193–196, 198, 201, 251, 286–287, 407–408, 414, 417, 460–461, 502–507, 572, 578, 586, 765–766, 786–789, 860–861, 884, 899, 904, 909, 916, 922, 925–927, 930–933, 936–938, 966, 1019–1020, 1101–1102, 1106, 1127, 1161, 1261–1262, 1338–1339, 1341, 1496–1497, 1586–1587, 1590, 1611, 1626, 1632, 1638, 1645, 1651, 1654–1656, 1659–1662, 1665–1667, 1694, 1839, 1851–1860, 1902, 1905–1910, 1913–1917, 2086–2090, 2189–2190, 2396–2406, 2409, 2418–2423, 2457–2459, 2493–2496, 2564–2568, 2577, 2666–2671, 2684, 2699, 2714
utils.py	910	33	96%	742–746, 891, 1210, 1226–1232, 1241–1242, 1983–1987, 2030–2034, 2077–2081, 2125–2129, 2199–2203, 2224, 2233, 2242, 2251–2252
views.py	145	33	77%	127–129, 134–135, 141–142, 185–188, 258–288, 299–314, 327–331
apps/sage_intacct/errors
errors.py	2	0	100%
helpers.py	47	1	98%	80
apps/sage_intacct/exports
ap_payments.py	13	0	100%
bills.py	28	0	100%
charge_card_transactions.py	22	0	100%
expense_reports.py	28	0	100%
helpers.py	56	2	96%	68, 141
journal_entries.py	76	8	89%	177–180, 316–319
reimbursements.py	13	0	100%
apps/tasks
models.py	70	0	100%
serializers.py	6	0	100%
views.py	37	0	100%
apps/users
helpers.py	12	0	100%
models.py	53	0	100%
views.py	17	0	100%
apps/workspaces
actions.py	46	9	80%	65, 84–85, 103, 122–133, 147
enums.py	92	0	100%
helpers.py	8	0	100%
models.py	176	0	100%
permissions.py	34	9	74%	33, 59–67
serializers.py	43	1	98%	54
signals.py	31	0	100%
system_comments.py	19	0	100%
tasks.py	175	9	95%	53–59, 187–194, 235, 267–268, 379
utils.py	9	0	100%
views.py	329	9	97%	110–112, 139–142, 702–703
apps/workspaces/apis/advanced_settings
serializers.py	80	3	96%	260, 263, 266
triggers.py	10	0	100%
views.py	11	0	100%
apps/workspaces/apis/errors
serializers.py	20	0	100%
views.py	15	0	100%
apps/workspaces/apis/export_settings
helpers.py	73	0	100%
serializers.py	103	3	97%	267, 270, 273
triggers.py	56	2	96%	33–34
views.py	11	0	100%
apps/workspaces/apis/import_settings
serializers.py	141	18	87%	232–238, 243–249, 257–265, 283, 286, 314, 317–318, 326
triggers.py	47	1	98%	31
views.py	33	0	100%
fyle_integrations_imports
dataclasses.py	31	0	100%
models.py	23	0	100%
queues.py	34	5	85%	24, 99, 136, 148–149
signals.py	10	0	100%
tasks.py	127	81	36%	69–111, 120–126, 139–208, 212–227, 252–255, 257, 259, 264
fyle_integrations_imports/modules
base.py	188	10	95%	75, 91–92, 95, 126, 230–231, 237–238, 351
categories.py	177	33	81%	80, 96, 99–100, 103–104, 272–273, 283, 296, 298, 342, 351–355, 364–410
cost_centers.py	96	12	88%	132–133, 152–153, 162, 178, 180, 226, 235–239
expense_custom_fields.py	121	7	94%	83–88, 247, 263, 265, 294
merchants.py	106	25	76%	80–83, 111–129, 155–162, 179–180, 190, 203, 205, 235, 238–242
projects.py	123	40	67%	88, 103–168, 188–189, 199, 223, 270, 284–288
tax_groups.py	18	0	100%
webhook_attributes.py	130	6	95%	98, 100–102, 213–214
workers
actions.py	21	0	100%
helpers.py	43	0	100%
worker.py	56	5	91%	44–45, 77–78, 125
TOTAL	10878	930	91%

Tests	Skipped	Failures	Errors	Time
830	0 💤	0 ❌	0 🔥	1m 8s ⏱️

[github-actions]

Failure. Coverage is below 90%.

Diff Coverage
Diff: origin/master..HEAD, staged and unstaged changes

apps/mappings/tasks.py (100%)
apps/sage_intacct/helpers.py (66.7%): Missing lines 151,155-156,160

Total: 14 lines
Missing: 4 lines
Coverage: 71%

[github-actions]

Failure. Coverage is below 90%.

Diff Coverage
Diff: origin/master..HEAD, staged and unstaged changes

apps/mappings/tasks.py (100%)
apps/sage_intacct/helpers.py (66.7%): Missing lines 151,155-156,160

Total: 14 lines
Missing: 4 lines
Coverage: 71%

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

apps/sage_intacct/helpers.py (1)

87-94: ⚠️ Potential issue | 🟡 Minor

Double sync_dimensions call on first migration.

When validate_rest_api_connection successfully migrates a workspace, it calls sync_dimensions (line 160). Then check_interval_and_sync_dimension calls sync_dimensions again at line 92 (since destination_synced_at will still satisfy the condition). This results in two full dimension syncs back-to-back on the first run after migration.

Consider having validate_rest_api_connection return a boolean indicating whether a sync was performed, and skip the second sync here if so.

🤖 Fix all issues with AI agents

In `@apps/sage_intacct/helpers.py`:
- Around line 149-159: After updating the DB with
FeatureConfig.objects.filter(...).update(...), invalidate or update the cached
feature entry so subsequent calls to
FeatureConfig.get_feature_config(workspace_id=workspace_id,
key='migrated_to_rest_api') return True immediately; implement this by calling
the existing cache invalidation helper (e.g., FeatureConfig.invalidate_cache or
clear_cache) for that workspace/key or, if no helper exists, write a small
helper to set the cached value to True (or add a force_refresh flag to
get_feature_config and call it) right after the update so
get_sage_intacct_connection stops using the SOAP connector.

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
apps
exceptions.py	47	11	77%	27, 33, 39–44, 50, 56–61, 67, 73, 79–80
apps/fyle
actions.py	124	7	94%	214, 263, 319–323
constants.py	1	0	100%
helpers.py	235	14	94%	50–57, 66, 376, 470, 477–480, 483–484
models.py	338	21	94%	315–317, 321–323, 327–329, 333–335, 339–341, 345–347, 408, 530–551, 574, 591
queue.py	50	0	100%
serializers.py	41	0	100%
signals.py	35	6	83%	22, 55–56, 69–71
tasks.py	546	87	84%	132, 143–144, 147–148, 151–152, 174–175, 231–251, 263–268, 311–314, 339–343, 353–361, 400–410, 525–585, 906–910, 1048, 1059–1060, 1085–1086
views.py	172	15	91%	84–91, 145, 245–246, 290–291, 316–320, 413–417
apps/internal
actions.py	39	2	95%	31–32
helpers.py	36	13	64%	18–35
serializers.py	30	0	100%
tasks.py	92	32	65%	35–39, 66–71, 116, 128–179
views.py	83	1	99%	39
apps/internal/services
e2e_setup.py	59	0	100%
fixture_factory.py	59	3	95%	218–220
apps/mappings
constants.py	2	0	100%
exceptions.py	71	6	92%	69–71, 79–81
helpers.py	86	2	98%	93, 163
models.py	50	0	100%
schedules.py	15	0	100%
serializers.py	10	0	100%
signals.py	111	14	87%	90–92, 127, 179–184, 190–194, 200–203, 209–210
tasks.py	179	29	84%	118–119, 142–143, 146, 210–227, 255, 258, 261, 267, 270, 276, 316–318, 329, 407
utils.py	34	0	100%
views.py	46	4	91%	34–35, 114–115
apps/sage_intacct
actions.py	29	4	86%	21–22, 49–50
connector.py	847	19	98%	142, 318, 330, 336, 412, 1489, 1788, 1916–1917, 1984–1985, 2021–2022, 2052–2053, 2120–2121, 2156–2157
dependent_fields.py	290	42	86%	345, 381–384, 413–422, 424–425, 427–429, 431–432, 434–435, 437–438, 442–444, 488, 508, 548–550, 596–598, 646–652, 656–657
enums.py	25	0	100%
helpers.py	68	6	91%	58, 96, 151, 155–160
models.py	988	67	93%	78–79, 264–275, 405, 412, 456, 477–494, 567, 579, 629, 635, 670, 720–722, 736–749, 760, 796, 848–849, 949, 990, 1219, 1314–1317, 1361, 1363, 1455, 1559–1602, 1700, 1727, 1838, 2213–2215, 2277
queue.py	171	16	91%	45, 53, 58, 105, 130–133, 173, 187, 205–208, 243, 267–270, 305, 330–333
serializers.py	35	0	100%
tasks.py	1433	144	90%	105, 119, 152, 188–189, 193–196, 198, 201, 251, 286–287, 407–408, 414, 417, 460–461, 502–507, 572, 578, 586, 765–766, 786–789, 860–861, 884, 899, 904, 909, 916, 922, 925–927, 930–933, 936–938, 966, 1019–1020, 1101–1102, 1106, 1127, 1161, 1261–1262, 1338–1339, 1341, 1496–1497, 1586–1587, 1590, 1611, 1626, 1632, 1638, 1645, 1651, 1654–1656, 1659–1662, 1665–1667, 1694, 1839, 1851–1860, 1902, 1905–1910, 1913–1917, 2086–2090, 2189–2190, 2396–2406, 2409, 2418–2423, 2457–2459, 2493–2496, 2564–2568, 2577, 2666–2671, 2684, 2699, 2714
utils.py	910	33	96%	742–746, 891, 1210, 1226–1232, 1241–1242, 1983–1987, 2030–2034, 2077–2081, 2125–2129, 2199–2203, 2224, 2233, 2242, 2251–2252
views.py	145	33	77%	127–129, 134–135, 141–142, 185–188, 258–288, 299–314, 327–331
apps/sage_intacct/errors
errors.py	2	0	100%
helpers.py	47	1	98%	80
apps/sage_intacct/exports
ap_payments.py	13	0	100%
bills.py	28	0	100%
charge_card_transactions.py	22	0	100%
expense_reports.py	28	0	100%
helpers.py	56	2	96%	68, 141
journal_entries.py	76	8	89%	177–180, 316–319
reimbursements.py	13	0	100%
apps/tasks
models.py	70	0	100%
serializers.py	6	0	100%
views.py	37	0	100%
apps/users
helpers.py	12	0	100%
models.py	53	0	100%
views.py	17	0	100%
apps/workspaces
actions.py	46	9	80%	65, 84–85, 103, 122–133, 147
enums.py	92	0	100%
helpers.py	8	0	100%
models.py	176	0	100%
permissions.py	34	9	74%	33, 59–67
serializers.py	43	1	98%	54
signals.py	31	0	100%
system_comments.py	19	0	100%
tasks.py	175	9	95%	53–59, 187–194, 235, 267–268, 379
utils.py	9	0	100%
views.py	329	9	97%	110–112, 139–142, 702–703
apps/workspaces/apis/advanced_settings
serializers.py	80	3	96%	260, 263, 266
triggers.py	10	0	100%
views.py	11	0	100%
apps/workspaces/apis/errors
serializers.py	20	0	100%
views.py	15	0	100%
apps/workspaces/apis/export_settings
helpers.py	73	0	100%
serializers.py	103	3	97%	267, 270, 273
triggers.py	56	2	96%	33–34
views.py	11	0	100%
apps/workspaces/apis/import_settings
serializers.py	141	18	87%	232–238, 243–249, 257–265, 283, 286, 314, 317–318, 326
triggers.py	47	1	98%	31
views.py	33	0	100%
fyle_integrations_imports
dataclasses.py	31	0	100%
models.py	23	0	100%
queues.py	34	5	85%	24, 99, 136, 148–149
signals.py	10	0	100%
tasks.py	127	81	36%	69–111, 120–126, 139–208, 212–227, 252–255, 257, 259, 264
fyle_integrations_imports/modules
base.py	188	10	95%	75, 91–92, 95, 126, 230–231, 237–238, 351
categories.py	177	33	81%	80, 96, 99–100, 103–104, 272–273, 283, 296, 298, 342, 351–355, 364–410
cost_centers.py	96	12	88%	132–133, 152–153, 162, 178, 180, 226, 235–239
expense_custom_fields.py	121	7	94%	83–88, 247, 263, 265, 294
merchants.py	106	25	76%	80–83, 111–129, 155–162, 179–180, 190, 203, 205, 235, 238–242
projects.py	130	47	64%	88–91, 106–182, 202–203, 213, 237, 284, 298–302
tax_groups.py	18	0	100%
webhook_attributes.py	130	6	95%	98, 100–102, 213–214
workers
actions.py	21	0	100%
helpers.py	43	0	100%
worker.py	56	5	91%	44–45, 77–78, 125
TOTAL	10885	937	91%

Tests	Skipped	Failures	Errors	Time
830	0 💤	0 ❌	0 🔥	1m 9s ⏱️

[github-actions]

Failure. Coverage is below 90%.

Diff Coverage
Diff: origin/master..HEAD, staged and unstaged changes

apps/mappings/tasks.py (100%)
apps/sage_intacct/helpers.py (66.7%): Missing lines 151,155-156,160

Total: 14 lines
Missing: 4 lines
Coverage: 71%

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
apps
exceptions.py	47	11	77%	27, 33, 39–44, 50, 56–61, 67, 73, 79–80
apps/fyle
actions.py	124	7	94%	214, 263, 319–323
constants.py	1	0	100%
helpers.py	235	14	94%	50–57, 66, 376, 470, 477–480, 483–484
models.py	338	21	94%	315–317, 321–323, 327–329, 333–335, 339–341, 345–347, 408, 530–551, 574, 591
queue.py	50	0	100%
serializers.py	41	0	100%
signals.py	35	6	83%	22, 55–56, 69–71
tasks.py	546	87	84%	132, 143–144, 147–148, 151–152, 174–175, 231–251, 263–268, 311–314, 339–343, 353–361, 400–410, 525–585, 906–910, 1048, 1059–1060, 1085–1086
views.py	172	15	91%	84–91, 145, 245–246, 290–291, 316–320, 413–417
apps/internal
actions.py	39	2	95%	31–32
helpers.py	36	13	64%	18–35
serializers.py	30	0	100%
tasks.py	92	32	65%	35–39, 66–71, 116, 128–179
views.py	83	1	99%	39
apps/internal/services
e2e_setup.py	59	0	100%
fixture_factory.py	59	3	95%	218–220
apps/mappings
constants.py	2	0	100%
exceptions.py	71	6	92%	69–71, 79–81
helpers.py	86	2	98%	93, 163
models.py	50	0	100%
schedules.py	15	0	100%
serializers.py	10	0	100%
signals.py	111	14	87%	90–92, 127, 179–184, 190–194, 200–203, 209–210
tasks.py	179	29	84%	118–119, 142–143, 146, 210–227, 255, 258, 261, 267, 270, 276, 316–318, 329, 407
utils.py	34	0	100%
views.py	46	4	91%	34–35, 114–115
apps/sage_intacct
actions.py	29	4	86%	21–22, 49–50
connector.py	847	19	98%	142, 318, 330, 336, 412, 1489, 1788, 1916–1917, 1984–1985, 2021–2022, 2052–2053, 2120–2121, 2156–2157
dependent_fields.py	290	42	86%	345, 381–384, 413–422, 424–425, 427–429, 431–432, 434–435, 437–438, 442–444, 488, 508, 548–550, 596–598, 646–652, 656–657
enums.py	25	0	100%
helpers.py	68	2	97%	58, 96
models.py	988	67	93%	78–79, 264–275, 405, 412, 456, 477–494, 567, 579, 629, 635, 670, 720–722, 736–749, 760, 796, 848–849, 949, 990, 1219, 1314–1317, 1361, 1363, 1455, 1559–1602, 1700, 1727, 1838, 2213–2215, 2277
queue.py	171	16	91%	45, 53, 58, 105, 130–133, 173, 187, 205–208, 243, 267–270, 305, 330–333
serializers.py	35	0	100%
tasks.py	1433	144	90%	105, 119, 152, 188–189, 193–196, 198, 201, 251, 286–287, 407–408, 414, 417, 460–461, 502–507, 572, 578, 586, 765–766, 786–789, 860–861, 884, 899, 904, 909, 916, 922, 925–927, 930–933, 936–938, 966, 1019–1020, 1101–1102, 1106, 1127, 1161, 1261–1262, 1338–1339, 1341, 1496–1497, 1586–1587, 1590, 1611, 1626, 1632, 1638, 1645, 1651, 1654–1656, 1659–1662, 1665–1667, 1694, 1839, 1851–1860, 1902, 1905–1910, 1913–1917, 2086–2090, 2189–2190, 2396–2406, 2409, 2418–2423, 2457–2459, 2493–2496, 2564–2568, 2577, 2666–2671, 2684, 2699, 2714
utils.py	910	33	96%	742–746, 891, 1210, 1226–1232, 1241–1242, 1983–1987, 2030–2034, 2077–2081, 2125–2129, 2199–2203, 2224, 2233, 2242, 2251–2252
views.py	145	33	77%	127–129, 134–135, 141–142, 185–188, 258–288, 299–314, 327–331
apps/sage_intacct/errors
errors.py	2	0	100%
helpers.py	47	1	98%	80
apps/sage_intacct/exports
ap_payments.py	13	0	100%
bills.py	28	0	100%
charge_card_transactions.py	22	0	100%
expense_reports.py	28	0	100%
helpers.py	56	2	96%	68, 141
journal_entries.py	76	8	89%	177–180, 316–319
reimbursements.py	13	0	100%
apps/tasks
models.py	70	0	100%
serializers.py	6	0	100%
views.py	37	0	100%
apps/users
helpers.py	12	0	100%
models.py	53	0	100%
views.py	17	0	100%
apps/workspaces
actions.py	46	9	80%	65, 84–85, 103, 122–133, 147
enums.py	92	0	100%
helpers.py	8	0	100%
models.py	176	0	100%
permissions.py	34	9	74%	33, 59–67
serializers.py	43	1	98%	54
signals.py	31	0	100%
system_comments.py	19	0	100%
tasks.py	175	9	95%	53–59, 187–194, 235, 267–268, 379
utils.py	9	0	100%
views.py	329	9	97%	110–112, 139–142, 702–703
apps/workspaces/apis/advanced_settings
serializers.py	80	3	96%	260, 263, 266
triggers.py	10	0	100%
views.py	11	0	100%
apps/workspaces/apis/errors
serializers.py	20	0	100%
views.py	15	0	100%
apps/workspaces/apis/export_settings
helpers.py	73	0	100%
serializers.py	103	3	97%	267, 270, 273
triggers.py	56	2	96%	33–34
views.py	11	0	100%
apps/workspaces/apis/import_settings
serializers.py	141	18	87%	232–238, 243–249, 257–265, 283, 286, 314, 317–318, 326
triggers.py	47	1	98%	31
views.py	33	0	100%
fyle_integrations_imports
dataclasses.py	31	0	100%
models.py	23	0	100%
queues.py	34	5	85%	24, 99, 136, 148–149
signals.py	10	0	100%
tasks.py	127	81	36%	69–111, 120–126, 139–208, 212–227, 252–255, 257, 259, 264
fyle_integrations_imports/modules
base.py	188	10	95%	75, 91–92, 95, 126, 230–231, 237–238, 351
categories.py	177	33	81%	80, 96, 99–100, 103–104, 272–273, 283, 296, 298, 342, 351–355, 364–410
cost_centers.py	96	12	88%	132–133, 152–153, 162, 178, 180, 226, 235–239
expense_custom_fields.py	121	7	94%	83–88, 247, 263, 265, 294
merchants.py	106	25	76%	80–83, 111–129, 155–162, 179–180, 190, 203, 205, 235, 238–242
projects.py	130	47	64%	88–91, 106–182, 202–203, 213, 237, 284, 298–302
tax_groups.py	18	0	100%
webhook_attributes.py	130	6	95%	98, 100–102, 213–214
workers
actions.py	21	0	100%
helpers.py	43	0	100%
worker.py	56	5	91%	44–45, 77–78, 125
TOTAL	10885	933	91%

Tests	Skipped	Failures	Errors	Time
833	0 💤	0 ❌	0 🔥	1m 13s ⏱️

[github-actions]

---

Diff Coverage
Diff: origin/master..HEAD, staged and unstaged changes

apps/mappings/tasks.py (100%)
apps/sage_intacct/helpers.py (100%)

Total: 14 lines
Missing: 0 lines
Coverage: 100%

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
apps
exceptions.py	47	11	77%	27, 33, 39–44, 50, 56–61, 67, 73, 79–80
apps/fyle
actions.py	124	7	94%	214, 263, 319–323
constants.py	1	0	100%
helpers.py	235	14	94%	50–57, 66, 376, 470, 477–480, 483–484
models.py	338	21	94%	315–317, 321–323, 327–329, 333–335, 339–341, 345–347, 408, 530–551, 574, 591
queue.py	50	0	100%
serializers.py	41	0	100%
signals.py	35	6	83%	22, 55–56, 69–71
tasks.py	546	87	84%	132, 143–144, 147–148, 151–152, 174–175, 231–251, 263–268, 311–314, 339–343, 353–361, 400–410, 525–585, 906–910, 1048, 1059–1060, 1085–1086
views.py	172	15	91%	84–91, 145, 245–246, 290–291, 316–320, 413–417
apps/internal
actions.py	39	2	95%	31–32
helpers.py	36	13	64%	18–35
serializers.py	30	0	100%
tasks.py	92	32	65%	35–39, 66–71, 116, 128–179
views.py	83	1	99%	39
apps/internal/services
e2e_setup.py	59	0	100%
fixture_factory.py	59	3	95%	218–220
apps/mappings
constants.py	2	0	100%
exceptions.py	71	6	92%	69–71, 79–81
helpers.py	86	2	98%	93, 163
models.py	50	0	100%
schedules.py	15	0	100%
serializers.py	10	0	100%
signals.py	111	14	87%	90–92, 127, 179–184, 190–194, 200–203, 209–210
tasks.py	179	29	84%	118–119, 142–143, 146, 210–227, 255, 258, 261, 267, 270, 276, 316–318, 329, 407
utils.py	34	0	100%
views.py	46	4	91%	34–35, 114–115
apps/sage_intacct
actions.py	29	4	86%	21–22, 49–50
connector.py	847	19	98%	142, 318, 330, 336, 412, 1489, 1788, 1916–1917, 1984–1985, 2021–2022, 2052–2053, 2120–2121, 2156–2157
dependent_fields.py	290	42	86%	345, 381–384, 413–422, 424–425, 427–429, 431–432, 434–435, 437–438, 442–444, 488, 508, 548–550, 596–598, 646–652, 656–657
enums.py	25	0	100%
helpers.py	71	3	96%	59, 97, 151
models.py	988	67	93%	78–79, 264–275, 405, 412, 456, 477–494, 567, 579, 629, 635, 670, 720–722, 736–749, 760, 796, 848–849, 949, 990, 1219, 1314–1317, 1361, 1363, 1455, 1559–1602, 1700, 1727, 1838, 2213–2215, 2277
queue.py	171	16	91%	45, 53, 58, 105, 130–133, 173, 187, 205–208, 243, 267–270, 305, 330–333
serializers.py	35	0	100%
tasks.py	1433	144	90%	105, 119, 152, 188–189, 193–196, 198, 201, 251, 286–287, 407–408, 414, 417, 460–461, 502–507, 572, 578, 586, 765–766, 786–789, 860–861, 884, 899, 904, 909, 916, 922, 925–927, 930–933, 936–938, 966, 1019–1020, 1101–1102, 1106, 1127, 1161, 1261–1262, 1338–1339, 1341, 1496–1497, 1586–1587, 1590, 1611, 1626, 1632, 1638, 1645, 1651, 1654–1656, 1659–1662, 1665–1667, 1694, 1839, 1851–1860, 1902, 1905–1910, 1913–1917, 2086–2090, 2189–2190, 2396–2406, 2409, 2418–2423, 2457–2459, 2493–2496, 2564–2568, 2577, 2666–2671, 2684, 2699, 2714
utils.py	910	33	96%	742–746, 891, 1210, 1226–1232, 1241–1242, 1983–1987, 2030–2034, 2077–2081, 2125–2129, 2199–2203, 2224, 2233, 2242, 2251–2252
views.py	145	33	77%	127–129, 134–135, 141–142, 185–188, 258–288, 299–314, 327–331
apps/sage_intacct/errors
errors.py	2	0	100%
helpers.py	47	1	98%	80
apps/sage_intacct/exports
ap_payments.py	13	0	100%
bills.py	28	0	100%
charge_card_transactions.py	22	0	100%
expense_reports.py	28	0	100%
helpers.py	56	2	96%	68, 141
journal_entries.py	76	8	89%	177–180, 316–319
reimbursements.py	13	0	100%
apps/tasks
models.py	70	0	100%
serializers.py	6	0	100%
views.py	37	0	100%
apps/users
helpers.py	12	0	100%
models.py	53	0	100%
views.py	17	0	100%
apps/workspaces
actions.py	46	9	80%	65, 84–85, 103, 122–133, 147
enums.py	92	0	100%
helpers.py	8	0	100%
models.py	176	0	100%
permissions.py	34	9	74%	33, 59–67
serializers.py	43	1	98%	54
signals.py	31	0	100%
system_comments.py	19	0	100%
tasks.py	175	9	95%	53–59, 187–194, 235, 267–268, 379
utils.py	9	0	100%
views.py	329	9	97%	110–112, 139–142, 702–703
apps/workspaces/apis/advanced_settings
serializers.py	80	3	96%	260, 263, 266
triggers.py	10	0	100%
views.py	11	0	100%
apps/workspaces/apis/errors
serializers.py	20	0	100%
views.py	15	0	100%
apps/workspaces/apis/export_settings
helpers.py	73	0	100%
serializers.py	103	3	97%	267, 270, 273
triggers.py	56	2	96%	33–34
views.py	11	0	100%
apps/workspaces/apis/import_settings
serializers.py	141	18	87%	232–238, 243–249, 257–265, 283, 286, 314, 317–318, 326
triggers.py	47	1	98%	31
views.py	33	0	100%
fyle_integrations_imports
dataclasses.py	31	0	100%
models.py	23	0	100%
queues.py	34	5	85%	24, 99, 136, 148–149
signals.py	10	0	100%
tasks.py	127	81	36%	69–111, 120–126, 139–208, 212–227, 252–255, 257, 259, 264
fyle_integrations_imports/modules
base.py	188	10	95%	75, 91–92, 95, 126, 230–231, 237–238, 351
categories.py	177	33	81%	80, 96, 99–100, 103–104, 272–273, 283, 296, 298, 342, 351–355, 364–410
cost_centers.py	96	12	88%	132–133, 152–153, 162, 178, 180, 226, 235–239
expense_custom_fields.py	121	7	94%	83–88, 247, 263, 265, 294
merchants.py	106	25	76%	80–83, 111–129, 155–162, 179–180, 190, 203, 205, 235, 238–242
projects.py	130	47	64%	88–91, 106–182, 202–203, 213, 237, 284, 298–302
tax_groups.py	18	0	100%
webhook_attributes.py	130	6	95%	98, 100–102, 213–214
workers
actions.py	21	0	100%
helpers.py	43	0	100%
worker.py	56	5	91%	44–45, 77–78, 125
TOTAL	10888	934	91%

Tests	Skipped	Failures	Errors	Time
833	0 💤	0 ❌	0 🔥	1m 9s ⏱️

[github-actions]

---

Diff Coverage
Diff: origin/master..HEAD, staged and unstaged changes

apps/mappings/tasks.py (100%)
apps/sage_intacct/helpers.py (93.3%): Missing lines 151

Total: 17 lines
Missing: 1 line
Coverage: 94%

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

apps/sage_intacct/helpers.py (1)

88-93: ⚠️ Potential issue | 🟠 Major

Bug: sync_dimensions called twice on migration.

When validate_rest_api_connection succeeds for the first time, it calls sync_dimensions at line 164. Control then returns here, but the local workspace object (fetched at line 86) is stale — destination_synced_at is still None even though sync_dimensions just updated it via a separate query. So line 92 evaluates to True and sync_dimensions runs a second time.

Either skip the outer sync when validate_rest_api_connection already performed one (e.g., by returning a boolean), or remove the sync_dimensions call from inside validate_rest_api_connection and let the caller handle it.