-
Notifications
You must be signed in to change notification settings - Fork 0
Try deploy2 #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Try deploy2 #425
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # Generated by Django 3.2.14 on 2025-01-08 08:17 | ||
|
|
||
| from django.db import migrations, models | ||
|
|
||
|
|
||
| class Migration(migrations.Migration): | ||
|
|
||
| dependencies = [ | ||
| ('fyle', '0022_support_split_expense_grouping'), | ||
| ] | ||
|
|
||
| operations = [ | ||
| migrations.AddField( | ||
| model_name='expensegroupsettings', | ||
| name='created_by', | ||
| field=models.CharField(blank=True, help_text='Email of the user who created this record', max_length=255, null=True), | ||
| ), | ||
| migrations.AddField( | ||
| model_name='expensegroupsettings', | ||
| name='updated_by', | ||
| field=models.CharField(blank=True, help_text='Email of the user who last updated this record', max_length=255, null=True), | ||
| ), | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,6 +12,7 @@ | |
| from django.db import models | ||
| from django.db.models import Count, JSONField | ||
| from fyle_accounting_mappings.models import ExpenseAttribute | ||
| from fyle_accounting_mappings.mixins import AutoAddCreateUpdateInfoMixin | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove duplicate import. The -from fyle_accounting_mappings.mixins import AutoAddCreateUpdateInfoMixin |
||
|
|
||
| from apps.fyle.enums import ExpenseStateEnum, FundSourceEnum, PlatformExpensesEnum | ||
| from apps.workspaces.models import Workspace, WorkspaceGeneralSettings | ||
|
|
@@ -277,7 +278,7 @@ def get_default_split_expense_grouping(): | |
| ) | ||
|
|
||
|
|
||
| class ExpenseGroupSettings(models.Model): | ||
| class ExpenseGroupSettings(AutoAddCreateUpdateInfoMixin, models.Model): | ||
| """ | ||
| ExpenseGroupCustomizationSettings | ||
| """ | ||
|
|
@@ -338,7 +339,7 @@ class Meta: | |
| db_table = "expense_group_settings" | ||
|
|
||
| @staticmethod | ||
| def update_expense_group_settings(expense_group_settings: Dict, workspace_id: int): | ||
| def update_expense_group_settings(expense_group_settings: Dict, workspace_id: int, user): | ||
| settings = ExpenseGroupSettings.objects.get(workspace_id=workspace_id) | ||
| current_reimbursable_settings = list(settings.reimbursable_expense_group_fields) | ||
| current_ccc_settings = list(settings.corporate_credit_card_expense_group_fields) | ||
|
|
@@ -434,6 +435,7 @@ def update_expense_group_settings(expense_group_settings: Dict, workspace_id: in | |
| "import_card_credits": import_card_credits, | ||
| 'split_expense_grouping': expense_group_settings['split_expense_grouping'], | ||
| }, | ||
| user=user | ||
| ) | ||
|
|
||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # Generated by Django 3.2.14 on 2025-01-08 08:17 | ||
|
|
||
| from django.db import migrations, models | ||
|
|
||
|
|
||
| class Migration(migrations.Migration): | ||
|
|
||
| dependencies = [ | ||
| ('mappings', '0006_auto_20220909_1206'), | ||
| ] | ||
|
|
||
| operations = [ | ||
| migrations.AddField( | ||
| model_name='generalmapping', | ||
| name='created_by', | ||
| field=models.CharField(blank=True, help_text='Email of the user who created this record', max_length=255, null=True), | ||
| ), | ||
| migrations.AddField( | ||
| model_name='generalmapping', | ||
| name='updated_by', | ||
| field=models.CharField(blank=True, help_text='Email of the user who last updated this record', max_length=255, null=True), | ||
| ), | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # Generated by Django 3.2.14 on 2025-01-08 08:17 | ||
|
|
||
| from django.db import migrations, models | ||
|
|
||
|
|
||
| class Migration(migrations.Migration): | ||
|
|
||
| dependencies = [ | ||
| ('workspaces', '0041_auto_20241223_1102'), | ||
| ] | ||
|
|
||
| operations = [ | ||
| migrations.AddField( | ||
| model_name='workspacegeneralsettings', | ||
| name='created_by', | ||
| field=models.CharField(blank=True, help_text='Email of the user who created this record', max_length=255, null=True), | ||
| ), | ||
| migrations.AddField( | ||
| model_name='workspacegeneralsettings', | ||
| name='updated_by', | ||
| field=models.CharField(blank=True, help_text='Email of the user who last updated this record', max_length=255, null=True), | ||
| ), | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule fyle_integrations_imports
deleted from
c370d0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Consider using selective linting configuration instead of disabling checks completely
While there are legitimate linting issues in the codebase (primarily line length violations), completely disabling flake8 checks is not the best solution. Instead:
Create a
setup.cfgor.flake8configuration file to:Use inline
# noqacomments for legitimate exceptions like long URLs or data structuresThis maintains code quality while accommodating practical needs.
🔗 Analysis chain
Do not disable linting checks in the build process.
Commenting out the flake8 check reduces code quality guarantees and may allow problematic code to slip through. This change appears unrelated to the PR's primary objective of implementing user tracking.
Instead of disabling linting:
Let's verify if there are actual linting issues that need to be addressed:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 387
Script:
Length of output: 66359