Skip to content

Update fyne cli version#339

Closed
murrayinglis wants to merge 3 commits intofyne-io:developfrom
murrayinglis:update-fyne-cli-version
Closed

Update fyne cli version#339
murrayinglis wants to merge 3 commits intofyne-io:developfrom
murrayinglis:update-fyne-cli-version

Conversation

@murrayinglis
Copy link

Description:

Fixes #(issue)

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

  • Public APIs match existing style.
  • Any breaking changes have a deprecation path or have been discussed.
  • Updated the vendor folder (using go mod vendor).

@andydotxyz
Copy link
Member

This is quite a brittle change - it requires that the fyne tool inside the image matches what is expected by fyne-cross. This coupling will break a lot of builds as images and fyne-cross can be updated separately.

I recommend you read up and contribute to #334 instead.

@murrayinglis
Copy link
Author

This is quite a brittle change - it requires that the fyne tool inside the image matches what is expected by fyne-cross. This coupling will break a lot of builds as images and fyne-cross can be updated separately.

I recommend you read up and contribute to #334 instead.

Sure, will contribute to that so we can have a version check for the CLI tools

@andydotxyz
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants