Migrate widget_test's Color.withOpacity to Color.withValues#127
Closed
b-luk wants to merge 1 commit intofzyzcjy:masterfrom
Closed
Migrate widget_test's Color.withOpacity to Color.withValues#127b-luk wants to merge 1 commit intofzyzcjy:masterfrom
Color.withOpacity to Color.withValues#127b-luk wants to merge 1 commit intofzyzcjy:masterfrom
Conversation
Merged
9 tasks
Author
|
This breaks the current CI because the CI runs with the Flutter 3.10.0 SDK. Flutter's customer testing requires using the main channel Flutter SDK. I am disabling the customer test with flutter/tests#479. It can be re-enabled when this CI is updated and the tests pass on the main channel Flutter SDK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flutter/flutter#181093 makes
dart fixchangeColor.withOpacitytoColor.withValuesin this test.The
dart fixed code fails some screenshot tests, becauseColor.withValuesresults in a slightly different color thanColor.withOpacity.This PR forward-fixes the tests to use
Color.withValuesand updates the goldens to be the newColor.withValuesimages. This way the tests won't be affected/broken when flutter/flutter#181093 is merged.