Open
Conversation
*reduce duplication using an each loop *introduce an item class
*to allow for easy change of different csv files
Was directing to the menu.csv in a weird way and was breaking on heroku. Hopefully this fixes it.
everyday's menu has multiple items now
also fixed menu spec it discriptions adjusted menu to have an item that shows every day
fixing heroku? hopefully
so tests dont break when files change
changed to make tests simpler and less dependent of content that has a possibility to change
also renamed wdayconverter to weekdayconverter for clarity made day_to_num method a class method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making our indian food page dynamic