Skip to content

Commit a765bb0

Browse files
committed
Merge branch 'develop' into 132-fractional
2 parents eddedc5 + a8ab026 commit a765bb0

File tree

3 files changed

+56
-24
lines changed

3 files changed

+56
-24
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,5 @@ jobs:
2525
uses: JamesIves/github-pages-deploy-action@v4
2626
with:
2727
branch: gh-pages
28+
clean: true # Clean only if on the main branch
2829
folder: .
29-
target-folder: ${{ github.ref == 'refs/heads/main' && 'docs/index.html' || '' }} # Deploy to docs/index.html only if on main
30-
clean: ${{ github.ref == 'refs/heads/main' }} # Clean only if on the main branch

.github/workflows/ci.yml

Lines changed: 49 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
name: Lint and validate OpenAPI specs
22
on:
3-
- pull_request
3+
- push
4+
- pull_request_target
45
jobs:
56
lint:
67
name: Lint OpenAPI definition
@@ -12,10 +13,22 @@ jobs:
1213
uses: mhiew/redoc-lint-github-action@v4
1314
with:
1415
args: 'openapi/task_execution_service.openapi.yaml'
16+
validate:
17+
name: Validate OpenAPI definition
18+
runs-on: ubuntu-latest
19+
steps:
20+
- name: Check out head branch
21+
uses: actions/checkout@v4
22+
- name: Run OpenAPI Validate Action
23+
uses: swaggerexpert/swagger-editor-validate@v1
24+
with:
25+
definition-file: openapi/task_execution_service.openapi.yaml
26+
1527
diff:
1628
name: Show OpenAPI differences relative to target branch
1729
runs-on: ubuntu-latest
18-
if: ${{ github.event_name == 'pull_request' }}
30+
outputs:
31+
diff_generated: ${{ steps.upload-log.outputs.artifact_id }}
1932
steps:
2033
- name: Check out head branch
2134
uses: actions/checkout@v4
@@ -27,19 +40,39 @@ jobs:
2740
with:
2841
ref: ${{ github.event.pull_request.base.ref }}
2942
path: base
30-
- name: Run OpenAPI Diff Action
31-
uses: mvegter/openapi-diff-action@v0.23.5
43+
- name: Create output directory
44+
run: mkdir -p diff-artifacts/
45+
- name: Pull Docker Image
46+
run: docker pull openapitools/openapi-diff:2.0.1
47+
- name: Run openapi-diff tool
48+
run: |
49+
docker run --rm \
50+
-v $(pwd)/head:/head:ro \
51+
-v $(pwd)/base:/base:ro \
52+
-v $(pwd)/diff-artifacts:/local \
53+
openapitools/openapi-diff:2.0.1 \
54+
/base/openapi/task_execution_service.openapi.yaml \
55+
/head/openapi/task_execution_service.openapi.yaml \
56+
--markdown /local/diff.md 2> diff-artifacts/error.log
57+
- name: Get PR number
58+
id: get-pr-number
59+
run: |
60+
echo "${{ github.event.pull_request.number }}" > diff-artifacts/pr_number
61+
- name: Upload artifacts
62+
uses: actions/upload-artifact@v4
3263
with:
33-
head-spec: head/openapi/task_execution_service.openapi.yaml
34-
base-spec: base/openapi/task_execution_service.openapi.yaml
64+
name: diff-artifacts
65+
path: diff-artifacts/
66+
if-no-files-found: ignore
67+
- name: Check if OpenAPI Diff failed
68+
id: check-diff
69+
run: |
70+
if [ -s diff-artifacts/error.log ]; then
71+
echo "The diff failed. Please see artifact error.log."
72+
exit 1
73+
fi
3574
36-
validate:
37-
name: Validate OpenAPI definition
38-
runs-on: ubuntu-latest
39-
steps:
40-
- name: Check out head branch
41-
uses: actions/checkout@v4
42-
- name: Run OpenAPI Validate Action
43-
uses: char0n/swagger-editor-validate@v1
44-
with:
45-
definition-file: openapi/task_execution_service.openapi.yaml
75+
permissions:
76+
contents: read
77+
pull-requests: write
78+
issues: write

README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ Task Execution Service (TES) API
1212
================================
1313

1414
This repository is the home for the schema of the Task Execution Service (TES)
15-
API defined by the[Cloud Work Stream](https://www.ga4gh.org/work_stream/cloud/)
15+
API defined by the [Cloud Work Stream](https://www.ga4gh.org/work_stream/cloud/)
1616
of the [Global Alliance for Genomics and Health (GA4GH)](https://ga4gh.org/).
1717
The goal of the API standard is to provide a uniform way to executing batch
1818
computing tasks.
@@ -92,11 +92,11 @@ handling personal data.
9292
> performed on latest versions of implementations available in December 2020.
9393
> Information may be outdated.
9494
95-
| | cwl-tes | Cromwell | Nextflow |
96-
| ----------- | ------------- | --------- | ---------|
97-
| **Funnel** | [Compatible](https://github.com/ohsu-comp-bio/cwl-tes) | Compatible | [Compatible](https://www.nextflow.io/docs/latest/executor.html#ga4gh-tes) |
98-
| **TESK** | [Compatible](https://github.com/ohsu-comp-bio/cwl-tes/pull/25) | [Compatible](https://cromwell.readthedocs.io/en/stable/backends/TES/) | [Compatible](https://github.com/EMBL-EBI-TSI/tesk-core/pull/19) |
99-
| **TES Azure** | Not tested | [Compatible](https://github.com/microsoft/CromwellOnAzure) | [Compatible](https://www.nextflow.io/docs/stable/executor.html#ga4gh-tes) |
95+
| | cwl-tes | Cromwell | Nextflow | Snakemake |
96+
| ----------- | ------------- | --------- | ---------| --------- |
97+
| **Funnel** | [Compatible](https://github.com/ohsu-comp-bio/cwl-tes) | Compatible | [Compatible](https://www.nextflow.io/docs/latest/executor.html#ga4gh-tes) | [Compatible](https://snakemake.readthedocs.io/en/stable/executing/cloud.html#executing-a-snakemake-workflow-via-ga4gh-tes) |
98+
| **TESK** | [Compatible](https://github.com/ohsu-comp-bio/cwl-tes/pull/25) | [Compatible](https://cromwell.readthedocs.io/en/stable/backends/TES/) | [Compatible](https://github.com/EMBL-EBI-TSI/tesk-core/pull/19) | [Compatible](https://github.com/EMBL-EBI-TSI/tesk-core/pull/19) | [Compatible](https://github.com/elixir-cloud-aai/demo-tes-hybrid-cloud/tree/main) |
99+
| **TES Azure** | Not tested | [Compatible](https://github.com/microsoft/CromwellOnAzure) | [Compatible](https://www.nextflow.io/docs/stable/executor.html#ga4gh-tes) | [Compatible](https://github.com/microsoft/ga4gh-tes/blob/main/snakemake/examples/snakemake/README.md) |
100100

101101

102102
TES Service Examples

0 commit comments

Comments
 (0)