Check for "text/html" content-type before attempting to get the URI d…#25
Open
sshen81 wants to merge 4 commits intogabceb:masterfrom
Open
Check for "text/html" content-type before attempting to get the URI d…#25sshen81 wants to merge 4 commits intogabceb:masterfrom
sshen81 wants to merge 4 commits intogabceb:masterfrom
Conversation
Owner
|
Cant we avoid the HEAD request and just check on the content-type header before we load cheerio with the response body. Relevant code: https://github.com/gabceb/node-metainspector/blob/master/index.js#L307 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When provided a URI that is not a valid text/html document, passing the data into cheerio can result in a call stack overflow.
This modification performs a HEAD request first & verifies that the URI content-type response header contains 'text/html'. If it does not, the meta inspector will emit an invalid data type error.