Skip to content

make width and height accept string or number#53

Open
natepappenhagen wants to merge 1 commit intogabidavila:masterfrom
natepappenhagen:patch-1
Open

make width and height accept string or number#53
natepappenhagen wants to merge 1 commit intogabidavila:masterfrom
natepappenhagen:patch-1

Conversation

@natepappenhagen
Copy link

image

Currently, height and width are have PropTypes that limit the values to be only numbers.

But, the <svg/> tag doesn't have such a limitation, making valid height/width arguments like this

    <USAMap
      customize={stateConfigurations}
      defaultFill="#F8F8F8"
      height={'100%'}
      width={'100%'}
    />

Very noisy in the console.

@natepappenhagen
Copy link
Author

@gabidavila

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant