Enabled bin_to_hex utest for stdformat, fixed std::formatter#3315
Merged
gabime merged 5 commits intogabime:v1.xfrom Jan 11, 2025
Merged
Enabled bin_to_hex utest for stdformat, fixed std::formatter#3315gabime merged 5 commits intogabime:v1.xfrom
gabime merged 5 commits intogabime:v1.xfrom
Conversation
Owner
|
Thanks. Please fix the ci |
Contributor
Author
Fixed, had to do another change to test_sink.h as explicit conversion was needed |
Owner
|
Merged. Thanks @koniarik ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out it's not hard to fix bin_to_hex to be compatible with std::format - the std::formatter overload just has to be copyable.
Made the fix, and enabled the utest for bin_to_hex in Mac CI for verification that fix works