feat: allow usage of --prune with --preserve-dir

[Fraguinha]

Status

IN DEVELOPMENT

Description

Adds support for: #445 (allow using both --prune and --preserve-dir flags)

[gabrie30]

@Fraguinha added you as a contributor, might have an email. But hoping it will fix the issue with the tests running properly

[Fraguinha]

I have accepted the invite

about the changes, I have made getRelativePathRepositories return an array of relative paths of repositories within outputDirAbsolutePath

in sliceContainsNamedRepo I also made it compare the repo.Path instead of only it's base

now the prunning logic in the pruneRepos function should be correctly removing the repositories missing from remote with:

os.RemoveAll(filepath.Join(outputDirAbsolutePath, repository))

let me know what you think of the approach, this current version is also no longer segregating the logic between the --preserve-dir --prune and the default behavior that existed previously so if needed I can try and add that back in a follow up commit

[gabrie30]

Thanks @Fraguinha I'll take a look when I can

[gabrie30]

The behavior I'm seeing now is that its trying to delete all the repos, I'm running the tests here using the --prune-no-confirm flag. I'll try to take a look this weekend, if you dont get to it before then. Appreciate the efforts, this is a tricky feature.

[Fraguinha]

Whoops, my bad, I think I understood why all the repos were being deleted...

repo.Path has a / prefix e.g: /group/group/group/repo while my function returns group/group/group/repo so in sliceContainsNamedRepo the comparison would always fail resulting in all repositories being pruned

I believe now the feature should be working correctly, sorry for the trouble

[gabrie30]

Thanks @Fraguinha!

[derekhe]

I had a problem using this feature under windows. Seems it deletes everything just cloned.