feat: add support for buildx create --annotations flag#690
Merged
gabrieldemarmiesse merged 8 commits intogabrieldemarmiesse:masterfrom Nov 17, 2025
Merged
feat: add support for buildx create --annotations flag#690gabrieldemarmiesse merged 8 commits intogabrieldemarmiesse:masterfrom
gabrieldemarmiesse merged 8 commits intogabrieldemarmiesse:masterfrom
Conversation
Owner
|
Very cool, thanks! Can you add a few unit tests? |
gabrieldemarmiesse
requested changes
Oct 24, 2025
Owner
gabrieldemarmiesse
left a comment
gabrieldemarmiesse
left a comment
There was a problem hiding this comment.
Thanks a lot for the PR! Just a few changes and we can merge :)
|
|
||
|
|
||
| @patch("python_on_whales.components.buildx.imagetools.cli_wrapper.run") | ||
| def test_imagetools_create_with_annotations_command_construction(mock_run): |
There was a problem hiding this comment.
Would it be possible in addition of this patched test to have a test running the real command? To make sure the inputs and outputs are what is expected by the real buildkit engine?
Contributor
Author
There was a problem hiding this comment.
Sorry about that, I'd run into a strange error and lazily mocked the test instead of actually understanding what was wrong. Fixed that now.
gabrieldemarmiesse
approved these changes
Nov 17, 2025
Owner
gabrieldemarmiesse
left a comment
gabrieldemarmiesse
left a comment
There was a problem hiding this comment.
Awesome thanks! And sorry for the delay!
gabrieldemarmiesse
merged commit 1c681d7
into
gabrieldemarmiesse:master
21 checks passed
Contributor
Author
|
No worries, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.