Potential better Podman support via client inheritance#697
Closed
Hasnainz wants to merge 0 commit intogabrieldemarmiesse:masterfrom
Closed
Potential better Podman support via client inheritance#697Hasnainz wants to merge 0 commit intogabrieldemarmiesse:masterfrom
Hasnainz wants to merge 0 commit intogabrieldemarmiesse:masterfrom
Conversation
LewisGaul
reviewed
Dec 20, 2025
Collaborator
LewisGaul
left a comment
There was a problem hiding this comment.
I've posted some high-level design thoughts at #592 (comment) - the comments I've left relate to what I've written there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A PR based on discussion from this issue and this discussion, to consider a potential solution for modifying PoW to have better Podman support. Comments are very welcome.
This PR adds Podman support by introducing a private
_BaseContainerEngineClientwhich is inherited by aPodmanClientand the normalDockerClient.SystemInfohas been split intoPodmanSystemInfoandDockerSystemInfoas an example of how future Podman and Docker specific changes will look in the future but can be split into a different PR if preferred.Code Changes
DockerSystemInfowith aSystemInfo = DockerSystemInfotype aliasPodmanSystemInfohas been added_BaseSystemCLIandDockerSystemCLIandPodmanSystemCLIboth inherit from it.DockerClienthas been changed to_BaseContainerEngineClientand a newDockerClientinherits from it. Docker specific functionality such asBuildxCLIhave been moved to theDockerClientPodmanClient(and future podman specific things)ContainerEngineClient(and future generic things)Test Changes
native_podman_clientfixture that returnsPodmanClient()for testing new Podman specific interactions.PodmanSystemInfo()and thatpodman.system.info()has correct valuesNote: Ideally we would update the existing podman tests (and I'm happy to make these changes) such that they run twice, once for the current
DockerClient(client_type='podman')and once for thenative_podman_clientbut that will increase test time, let me know what you think.Usage
Splitting into smaller PRs
After an quick overall review (to make sure that this PR is going in the correct direction based on the discussion) I am planning to split this PR into smaller PRs that are more easily reviewable,