Skip to content

Add support for --disable-dns when creating a network (podman)#709

Open
Hasnainz wants to merge 1 commit intogabrieldemarmiesse:masterfrom
Hasnainz:network-disable-dns
Open

Add support for --disable-dns when creating a network (podman)#709
Hasnainz wants to merge 1 commit intogabrieldemarmiesse:masterfrom
Hasnainz:network-disable-dns

Conversation

@Hasnainz
Copy link
Contributor

podman network create has an option to disable creating a dns process when making bridge networks, see documentation here. As far as I can tell docker doesn't have this flag?

Comment on lines 214 to 215
Parameters:
name: The name of the network
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realise there's a gap in that the docstring doesn't cover most of the options, but could you add this one since it's important we note that this is only valid for Podman.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a simple testcase, even if it just creates the network with the flag and checks network.dns_enabled (does this need adding to the model?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants