Add support for --disable-dns when creating a network (podman)#709
Open
Hasnainz wants to merge 1 commit intogabrieldemarmiesse:masterfrom
Open
Add support for --disable-dns when creating a network (podman)#709Hasnainz wants to merge 1 commit intogabrieldemarmiesse:masterfrom
Hasnainz wants to merge 1 commit intogabrieldemarmiesse:masterfrom
Conversation
LewisGaul
reviewed
Mar 19, 2026
Comment on lines
214
to
215
| Parameters: | ||
| name: The name of the network |
Collaborator
There was a problem hiding this comment.
I realise there's a gap in that the docstring doesn't cover most of the options, but could you add this one since it's important we note that this is only valid for Podman.
LewisGaul
reviewed
Mar 19, 2026
Collaborator
There was a problem hiding this comment.
Can we add a simple testcase, even if it just creates the network with the flag and checks network.dns_enabled (does this need adding to the model?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
podman network createhas an option to disable creating a dns process when making bridge networks, see documentation here. As far as I can tell docker doesn't have this flag?