Remember plugin across sessions + skip confirmation setting#5
Merged
gacarrillor merged 4 commits intogacarrillor:mainfrom Mar 19, 2025
Merged
Remember plugin across sessions + skip confirmation setting#5gacarrillor merged 4 commits intogacarrillor:mainfrom
gacarrillor merged 4 commits intogacarrillor:mainfrom
Conversation
nirvn
commented
Mar 19, 2025
Comment on lines
+86
to
+88
| onAboutToShow: { | ||
| comboBoxPlugins.currentIndex = comboBoxPlugins.indexOfValue(reloaderSettings.pluginUuid); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
@mbernasocchi , this is what I was suggesting here -- and since the plugin name is possibly not unique nor static, it's much better to rely on pluginUuid.
gacarrillor
approved these changes
Mar 19, 2025
| } | ||
|
|
||
| QfComboBox { | ||
| ComboBox { |
Owner
There was a problem hiding this comment.
To make sure I learn from this, is this recommended in general or is it because QfComboBox won't have the style we'd like to show?
Contributor
Author
There was a problem hiding this comment.
@gacarrillor , within dialog popups, using ComboBox feels a lot more natural than QfComboBox. Ideally in the future I'd like to reduce the visual difference between QfComboBox and ComboBox, but for now let's agree to the rule that if we have a combo box within a dialog popup, we go for ComboBox.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@gacarrillor , here's a a couple of improvements I added to the plugin to make it that much pleasant and faster to use :)
This supersedes @mbernasocchi 's PR here: #4