Merge pull request #364 from gadget-inc/lazy-routes

Use the lazy route table by default for faster initial pageloads

Author: airhorns

packages/fastify-renderer/src/node/renderers/react/ReactRenderer.tsx

@@ -37,7 +37,6 @@ const staticLocationHook = (path = '/', { record = false } = {}) => {
 
 export class ReactRenderer implements Renderer {
   static ROUTE_TABLE_ID = '/@fstr!route-table.js'
-  static LAZY_ROUTE_TABLE_ID = '/@fstr!lazy-route-table.js'
 
   viteConfig!: ResolvedConfig
   devServer?: ViteDevServer
@@ -312,7 +311,9 @@ export class ReactRenderer implements Renderer {
           // client side hydration entrypoint for a particular route generated by fastify-renderer
           import React from 'react'
           import ReactDOM from 'react-dom'
-          import { routes } from ${JSON.stringify(ReactRenderer.ROUTE_TABLE_ID + '?' + querystring.stringify({ base }))}
+          import { routes } from ${JSON.stringify(
+            ReactRenderer.ROUTE_TABLE_ID + '?' + querystring.stringify({ base, lazy: true })
+          )}
           import { Root } from ${JSON.stringify(this.clientModulePath)}
           import Layout from ${JSON.stringify(layout)}
           import Entrypoint from ${JSON.stringify(entrypoint)}

packages/test-apps/simple-react/test/switching-contexts.spec.ts

@@ -12,8 +12,9 @@ describe('navigation details', () => {
 
   test('navigating between pages of the same context doesnt trigger a server side render request', async () => {
     page.on('request', (request) => {
+      if (request.url().includes('/.vite/')) return
       if (request.headers().accept !== 'application/json') {
-        throw new Error(`Expecting request to only fetch props, request made: ${request.method()} ${request.url()}`)
+        throw new Error(`Expecting request to only fetch props, request made: ${request.method()} ${request.url()} $`)
       }
     })
 
@@ -22,6 +23,8 @@ describe('navigation details', () => {
 
   test('navigating between pages of different contexts triggers a server side render request', async () => {
     page.on('request', (request) => {
+      if (request.url().includes('/.vite/')) return
+
       if (request.headers().accept === 'application/json') {
         throw new Error(`Expecting request to trigger SSR, request made: ${request.method()} ${request.url()}`)
       }