[RFC] Call model's validate_fsm_state_change via Form.is_valid #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for validation on the model level for a transition that is about to happen (via `form.is_valid`). Raising ValidationError via `validate_fsm_state_change` allows for Django handling it properly, instead for when the ValidationError would be raised from the transition function itself.
blueyed
changed the title
|
It might also be possible and better to just set a property on the instance, which then could be used in the models |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for validation on the model level for a transition that is
about to happen (via
form.is_valid).Raising ValidationError via
validate_fsm_state_changeallows forDjango handling it properly, instead for when the ValidationError would
be raised from the transition function itself.
Ref: django/django#9113
Ref: viewflow/django-fsm#120