Merged
Conversation
_get_arguments_list warning testGaeaNodeResource tests
Zehir
requested changes
May 14, 2025
Collaborator
Zehir
left a comment
There was a problem hiding this comment.
I think all tests are needed but there is some improvements on errors message if that possible
Collaborator
|
I press the button to run all tests and he updated the file gdunitrunner.cfg {"included":{"res://testing":[]},"server_port":31002,"skipped":{},"version":"1.0"}I also removed the file and press the run all tests button and he was able to find all tests. I am still thinking this file should be gitignored because you define the path inside the yml file for the workflow it's not needed |
Collaborator
Author
gitignored it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a few tests to the nodes in the
root/directory:_get_argument_listis overriden."Unnamed"GaeaValue.Typeand that it isn't null.get_scenereturn is a validPackedSceneTO-DO:
get_sceneis a valid scene.