Skip to content

Add GaeaNodeResource tests#400

Merged
BenjaTK merged 16 commits intogaea-godot:2.0from
BenjaTK:warning_check
May 15, 2025
Merged

Add GaeaNodeResource tests#400
BenjaTK merged 16 commits intogaea-godot:2.0from
BenjaTK:warning_check

Conversation

@BenjaTK
Copy link
Collaborator

@BenjaTK BenjaTK commented May 12, 2025

Adds a few tests to the nodes in the root/ directory:

  • That _get_argument_list is overriden.
  • That its title isn't "Unnamed"
  • That its type is in GaeaValue.Type and that it isn't null.
  • That its arguments' types match that same condition.
  • That its outputs' types match that same condition.
  • That it has outputs.
  • That its get_scene return is a valid PackedScene

TO-DO:

  • Add non-null type check
  • Add non-null argument type check
  • Add non-empty description check
  • Check that it has outputs
  • Check non-null output type
  • Check that get_scene is a valid scene.

@BenjaTK BenjaTK marked this pull request as draft May 12, 2025 18:47
@BenjaTK BenjaTK changed the title Add _get_arguments_list warning test Add GaeaNodeResource tests May 14, 2025
@BenjaTK BenjaTK marked this pull request as ready for review May 14, 2025 13:34
Copy link
Collaborator

@Zehir Zehir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all tests are needed but there is some improvements on errors message if that possible

@Zehir
Copy link
Collaborator

Zehir commented May 14, 2025

I press the button to run all tests and he updated the file gdunitrunner.cfg

{"included":{"res://testing":[]},"server_port":31002,"skipped":{},"version":"1.0"}

I also removed the file and press the run all tests button and he was able to find all tests.

I am still thinking this file should be gitignored because you define the path inside the yml file for the workflow it's not needed

@BenjaTK
Copy link
Collaborator Author

BenjaTK commented May 14, 2025

I press the button to run all tests and he updated the file gdunitrunner.cfg

{"included":{"res://testing":[]},"server_port":31002,"skipped":{},"version":"1.0"}

I also removed the file and press the run all tests button and he was able to find all tests.

I am still thinking this file should be gitignored because you define the path inside the yml file for the workflow it's not needed

gitignored it

@BenjaTK BenjaTK requested a review from Zehir May 14, 2025 22:44
@BenjaTK BenjaTK merged commit 44910e2 into gaea-godot:2.0 May 15, 2025
2 checks passed
Copy link
Collaborator

@Zehir Zehir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenjaTK BenjaTK deleted the warning_check branch October 16, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants