Add GDLint as a workflow and re-format files to fit Godot's style guide

.gdlintrc

@@ -0,0 +1,48 @@
+class-definitions-order:
+- tools
+- classnames
+- extends
+- docstrings
+- signals
+- enums
+- consts
+- exports
+- pubvars
+- prvvars
+- onreadypubvars
+- onreadyprvvars
+- staticvars
+- others
+class-load-variable-name: (([A-Z][a-z0-9]*)+|_?[a-z][a-z0-9]*(_[a-z0-9]+)*)
+class-name: ([A-Z][a-z0-9]*)+
+class-variable-name: _?[a-z][a-z0-9]*(_[a-z0-9]+)*
+comparison-with-itself: null
+constant-name: _?[A-Z][A-Z0-9]*(_[A-Z0-9]+)*
+disable: []
+duplicated-load: null
+enum-element-name: '[A-Z][A-Z0-9]*(_[A-Z0-9]+)*'
+enum-name: ([A-Z][a-z0-9]*)+
+excluded_directories: !!set
+  .git: null
+expression-not-assigned: null
+function-argument-name: _?[a-z][a-z0-9]*(_[a-z0-9]+)*
+function-arguments-number: 10
+function-name: (_on_([A-Z][a-z0-9]*)+(_[a-z0-9]+)*|_?[a-z][a-z0-9]*(_[a-z0-9]+)*)
+function-preload-variable-name: ([A-Z][a-z0-9]*)+
+function-variable-name: '[a-z][a-z0-9]*(_[a-z0-9]+)*'
+load-constant-name: (([A-Z][a-z0-9]*)+|_?[A-Z][A-Z0-9]*(_[A-Z0-9]+)*)
+loop-variable-name: _?[a-z][a-z0-9]*(_[a-z0-9]+)*
+max-file-lines: 1000
+max-line-length: 140
+max-public-methods: 999
+max-returns: 20
+mixed-tabs-and-spaces: null
+no-elif-return: null
+no-else-return: null
+private-method-call: null
+signal-name: '[a-z][a-z0-9]*(_[a-z0-9]+)*'
+sub-class-name: _?([A-Z][a-z0-9]*)+
+tab-characters: 1
+trailing-whitespace: null
+unnecessary-pass: null
+unused-argument: null

.github/workflows/gdlint.yml

@@ -0,0 +1,43 @@
+name: GHA
+
+run-name: ${{ github.head_ref || github.ref_name }}-gdlint
+
+on:
+  workflow_call:
+  workflow_dispatch:
+
+jobs:
+  gdlint:
+    name: Formatting Checks
+    runs-on: 'ubuntu-22.04'
+    timeout-minutes: 5
+
+    steps:
+      - name: Checkout GdUnit Repository
+        uses: actions/checkout@v5
+        with:
+          lfs: true
+
+      - name: "Setup GDLint"
+        uses: Scony/godot-gdscript-toolkit@master
+        with:
+          version: 4.5.0
+
+      - name: "Run GDLint"
+        id: run-gdlint
+        shell: bash
+        run: |
+          mkdir -p reports/gdlint/
+          gdlint addons/gaea/editor/ | tee reports/gdlint/editor.txt
+          gdlint addons/gaea/graph/ | tee reports/gdlint/graph.txt
+          gdlint addons/gaea/nodes/ | tee reports/gdlint/nodes.txt
+          gdlint addons/gaea/resources/ | tee reports/gdlint/resources.txt
+
+      - name: "Upload GDLint Report"
+        if: failure()
+        uses: actions/upload-artifact@v4
+        with:
+          name: gdlint.txt
+          path: reports/gdlint/**
+          if-no-files-found: error
+          compression-level: 0 # no compression

.github/workflows/generation_testing.yml

@@ -1,10 +1,7 @@
 name: GHA
 
 on:
-  pull_request:
-    paths-ignore:
-      - '**.yml'
-      - '**.md'
+  workflow_call:
   workflow_dispatch:
 
 
@@ -15,8 +12,8 @@ concurrency:
 
 jobs:
   generate_test:
-    name: "Generation Testing"
-    runs-on: 'ubuntu-22.04'
+    name: Tests
+    runs-on: 'ubuntu-24.04'
     timeout-minutes: 10 # The overall timeout
     permissions:
       actions: write
@@ -27,7 +24,7 @@ jobs:
 
     steps:
       # checkout your repository
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
         with:
           lfs: true
       # run tests by using the gdUnit4-action with Godot version 4.2.1 and the latest GdUnit4 release 
@@ -38,3 +35,4 @@ jobs:
             res://testing/generation
           timeout: 5
           publish-report: false
+          report-name: generation-gdunit4

.github/workflows/nodes_testing.yml

@@ -1,10 +1,7 @@
 name: GHA
 
 on:
-  pull_request:
-    paths-ignore:
-      - '**.yml'
-      - '**.md'
+  workflow_call:
   workflow_dispatch:
 
 
@@ -15,8 +12,8 @@ concurrency:
 
 jobs:
   warning_check:
-    name: "Node Testing"
-    runs-on: 'ubuntu-22.04'
+    name: Tests
+    runs-on: 'ubuntu-24.04'
     timeout-minutes: 10 # The overall timeout
     permissions:
       actions: write
@@ -38,3 +35,4 @@ jobs:
             res://testing/graph_nodes
           timeout: 5
           publish-report: false
+          report-name: nodes-gdunit4

.github/workflows/on-prs.yml

@@ -0,0 +1,67 @@
+name: GHA
+
+run-name: ${{ github.head_ref || github.ref_name }}-gha
+
+on: # yamllint disable-line rule:truthy
+  pull_request:
+    paths-ignore:
+      - '**.yml'
+      - '**.md'
+  workflow_dispatch:
+
+concurrency:
+  group: gha-${{ github.event.number }}
+  cancel-in-progress: true
+
+
+jobs:
+  gdlint:
+    if: ${{ !cancelled() }}
+    name: '📝 GDLint'
+    uses: ./.github/workflows/gdlint.yml
+
+  generation_testing:
+    name: '🐞 Generation'
+    uses: ./.github/workflows/generation_testing.yml
+
+    permissions:
+      actions: write
+      checks: write
+      contents: write
+      pull-requests: write
+      statuses: write
+
+  nodes_testing:
+    name: '🐞 Node'
+    uses: ./.github/workflows/nodes_testing.yml
+
+    permissions:
+      actions: write
+      checks: write
+      contents: write
+      pull-requests: write
+      statuses: write
+
+  renderers_testing:
+    name: '🐞 Renderers'
+    uses: ./.github/workflows/renderers_testing.yml
+
+    permissions:
+      actions: write
+      checks: write
+      contents: write
+      pull-requests: write
+      statuses: write
+
+  other_testing:
+    name: '🐞 Other'
+    uses: ./.github/workflows/other_testing.yml
+
+    permissions:
+      actions: write
+      checks: write
+      contents: write
+      pull-requests: write
+      statuses: write
+
+

.github/workflows/other_testing.yml

@@ -1,10 +1,7 @@
 name: GHA
 
 on:
-  pull_request:
-    paths-ignore:
-      - '**.yml'
-      - '**.md'
+  workflow_call:
   workflow_dispatch:
 
 
@@ -15,8 +12,8 @@ concurrency:
 
 jobs:
   warning_check:
-    name: "Other Testing"
-    runs-on: 'ubuntu-22.04'
+    name: Tests
+    runs-on: 'ubuntu-24.04'
     timeout-minutes: 10 # The overall timeout
     permissions:
       actions: write
@@ -27,7 +24,7 @@ jobs:
 
     steps:
       # checkout your repository
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
         with:
           lfs: true
       # run tests by using the gdUnit4-action with Godot version 4.2.1 and the latest GdUnit4 release 
@@ -38,3 +35,4 @@ jobs:
             res://testing/other
           timeout: 5
           publish-report: false
+          report-name: other-gdunit4

.github/workflows/renderers_testing.yml

@@ -1,10 +1,7 @@
 name: GHA
 
 on:
-  pull_request:
-    paths-ignore:
-      - '**.yml'
-      - '**.md'
+  workflow_call:
   workflow_dispatch:
 
 
@@ -15,8 +12,8 @@ concurrency:
 
 jobs:
   warning_check:
-    name: "Rendering Testing"
-    runs-on: 'ubuntu-22.04'
+    name: Tests
+    runs-on: 'ubuntu-24.04'
     timeout-minutes: 10 # The overall timeout
     permissions:
       actions: write
@@ -27,7 +24,7 @@ jobs:
 
     steps:
       # checkout your repository
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
         with:
           lfs: true
       # run tests by using the gdUnit4-action with Godot version 4.2.1 and the latest GdUnit4 release 
@@ -38,3 +35,4 @@ jobs:
             res://testing/rendering
           timeout: 5
           publish-report: false
+          report-name: rendering-gdunit4

addons/gaea/editor/about_window.gd

@@ -1,7 +1,6 @@
 @tool
 extends AcceptDialog
 
-
 const CONTRIBUTORS_LIST := "res://addons/gaea/contributors.txt"
 
 var plugin: EditorPlugin
@@ -12,19 +11,24 @@ var plugin: EditorPlugin
 @onready var _version_label: LinkButton = %VersionLabel
 
 
-
 func initialize() -> void:
 	if is_part_of_edited_scene():
 		return
 
 	_version_label.text = "Gaea %s" % plugin.get_plugin_version()
 	_version_label.uri = "https://github.com/gaea-godot/gaea/releases/tag/%s" % plugin.get_plugin_version()
 	_version_label.tooltip_text = _version_label.uri
-	_contributors_panel.add_theme_stylebox_override(&"panel", EditorInterface.get_base_control().get_theme_stylebox(&"LaunchPadNormal", &"EditorStyles"))
+	_contributors_panel.add_theme_stylebox_override(
+		&"panel",
+		EditorInterface.get_base_control().get_theme_stylebox(&"LaunchPadNormal", &"EditorStyles")
+	)
 	for child in _main_vbox.get_children():
 		if child is not PanelContainer:
 			continue
-		child.add_theme_stylebox_override(&"panel", EditorInterface.get_base_control().get_theme_stylebox(&"Background", &"EditorStyles"))
+		child.add_theme_stylebox_override(
+			&"panel",
+			EditorInterface.get_base_control().get_theme_stylebox(&"Background", &"EditorStyles")
+		)
 
 	var contributors: Array[String]
 	var file := FileAccess.open(CONTRIBUTORS_LIST, FileAccess.READ)

addons/gaea/editor/create_node_popup.gd

@@ -1,7 +1,6 @@
 @tool
 extends Window
 
-
 @onready var cancel_button: Button = %CancelButton
 @onready var tool_button: Button = %ToolButton
 @onready var tool_popup: PopupMenu = %ToolPopup