Skip to content

Properly save and load scroll offset and zoom #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenjaTK merged 2 commits into from
Oct 13, 2025
Merged

Properly save and load scroll offset and zoom #460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5aa793c
Properly save and load scroll offset and zoom
BenjaTK Oct 13, 2025
a9e6fcd
Fix wrong tabulation
BenjaTK Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions addons/gaea/editor/panel.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ var is_loading = false
## Local position on [GraphEdit] for a node that may be created in the future.
var _node_creation_target: Vector2 = Vector2.ZERO
var plugin: EditorPlugin
var _scroll_offsets: Dictionary[GaeaGraph, Vector2]
var _zooms: Dictionary[GaeaGraph, float]

@onready var _no_data: Control = $NoData
@onready var _editor: Control = $Editor
Expand Down Expand Up @@ -166,16 +164,22 @@ func _load_data() -> void:
if not has_output_node:
_output_node = _add_node(GaeaNodeOutput.new(), Vector2.ZERO)

# If scroll offset is saved, set it to that. Else, center the output node.
_graph_edit.set_scroll_offset(_scroll_offsets.get(_selected_generator.data, _output_node.size * 0.5 - _graph_edit.get_rect().size * 0.5))
_graph_edit.set_zoom(_zooms.get(_selected_generator.data, 1.0))


_load_scroll_offset.call_deferred(
_output_node.size * 0.5 - _graph_edit.get_rect().size * 0.5
)

# from_node and to_node are indexes in the resources array
_load_connections.call_deferred(_selected_generator.data.get_all_connections())

update_connections()
is_loading = false
set_deferred(&"is_loading", false)


func _load_scroll_offset(default_offset: Vector2) -> void:
if is_nan(_selected_generator.data.scroll_offset.x):
_selected_generator.data.scroll_offset = default_offset
_graph_edit.set_scroll_offset(_selected_generator.data.scroll_offset)
_graph_edit.set_zoom(_selected_generator.data.zoom)


func _load_connections(connections: Array[Dictionary]) -> void:
Expand Down Expand Up @@ -506,7 +510,10 @@ func update_bottom_note():


func _on_graph_edit_scroll_offset_changed(offset: Vector2) -> void:
if is_loading:
return

if is_instance_valid(_selected_generator):
if is_instance_valid(_selected_generator.data):
_scroll_offsets.set(_selected_generator.data, offset)
_zooms.set(_selected_generator.data, _graph_edit.zoom)
_selected_generator.data.scroll_offset = offset
_selected_generator.data.zoom = _graph_edit.zoom
6 changes: 6 additions & 0 deletions addons/gaea/resources/gaea_graph.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,12 @@ var parameters: Dictionary[StringName, Variant]
var other: Dictionary
## The current save version, used for migrating checks.
@export_storage var save_version: int = -1
## The graph's [member GraphEdit.scroll_offset]. Only saved
## in the current session.
var scroll_offset: Vector2 = Vector2(NAN, NAN)
## The graph's [member GraphEdit.zoom]. Only saved
## in the current session.
var zoom: float = 1.0

## The currently related generator.
var generator: GaeaGenerator
Expand Down
Loading