Remove GraphNode reference from NodeResource#576
Draft
Zehir wants to merge 3 commits intogaea-godot:2.0from
Draft
Remove GraphNode reference from NodeResource#576Zehir wants to merge 3 commits intogaea-godot:2.0from
Zehir wants to merge 3 commits intogaea-godot:2.0from
Conversation
Zehir
added
the
organization
Zehir
requested review from
BenjaTK and
cullumi
and removed request for
cullumi
Collaborator
Author
|
The tests are failing because this PR need #574 first |
Collaborator
|
I think this needs to be finished before I can move on with #521 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an other step for #573
This PR remove the
nodeproperty from theGaeaGraphNodeclass.It's now using instead a meta value with the key
&"_gaea_graph_node".