Closed
Conversation
Zehir
added
🐞 bug
Collaborator
|
This can be made more cleanly with #521 |
Collaborator
Author
Yes I think about that too but there is too many open PR to move that many files, we will get too many conflicts. I could handle it in a cleaner split if we merge the other PRs |
Collaborator
|
I can work on it after we merge the other PRs, will get to reviewing today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the last step for #573.
The idea here is to exclude editor-only resources and scripts from exports.
The main script is ignored (GaeaEditorPlugin, a.k.a.
gaea.gd). This script holds many references to editor-only scripts and has no purpose in the game logic.The following directories are ignored:
res://addons/gaea/editor/res://addons/gaea/graph/components/res://addons/gaea/assets/The following classes, child classes, or scenes whose root node has a matching script are also ignored:
GaeaGraphNodeGaeaGraphFrameGaeaGraphNodeArgumentEditorNow, every file that gets shipped with the game should be able to run at runtime and exported game. As a result, no references to editor scripts are allowed.