Skip to content

Upgrade all project files for 4.6#580

Merged
BenjaTK merged 1 commit intogaea-godot:2.0from
BenjaTK:upgrade-files
Feb 18, 2026
Merged

Upgrade all project files for 4.6#580
BenjaTK merged 1 commit intogaea-godot:2.0from
BenjaTK:upgrade-files

Conversation

@BenjaTK
Copy link
Collaborator

@BenjaTK BenjaTK commented Feb 16, 2026

Ran the Upgrade Project Files tool that Godot provides.

@Zehir
Copy link
Collaborator

Zehir commented Feb 16, 2026

I don't think it's was a good idea for the GDUnit4 plugin, there is a ton of runtime stuff that got saved, lot of cached stuff. I think you should revert the changed in the gdunit4 directory and keep only the changes for thoses that get updated on Godot load;
image

@BenjaTK
Copy link
Collaborator Author

BenjaTK commented Feb 17, 2026

[...] there is a ton of runtime stuff that got saved [...]

I'm not sure what you mean. These are all things Godot would do automatically if we even touched the files, so it makes sure those changes don't get added into future commits by making them now.

@Zehir
Copy link
Collaborator

Zehir commented Feb 18, 2026

I think the addon is missing some "is part of edited scene" check, look what's got added in the file;
‎testing/rendering/gridmap_test_scene.tscn‎
‎addons/gdUnit4/src/ui/GdUnitConsole.tscn
‎‎addons/gdUnit4/src/ui/settings/GdUnitSettingsDialog.tscn‎

It's not a big issue I guess because those files are not in the final addon

@BenjaTK
Copy link
Collaborator Author

BenjaTK commented Feb 18, 2026

It's not a big issue I guess because those files are not in the final addon

yeahh, it's mainly repository clean-up.

@BenjaTK BenjaTK requested a review from Zehir February 18, 2026 12:56
@BenjaTK BenjaTK merged commit 3214269 into gaea-godot:2.0 Feb 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants