Fix GaeaNodesCopy serialization to text#581
Merged
Zehir merged 1 commit intogaea-godot:2.0from Feb 18, 2026
Merged
Conversation
BenjaTK
added
🐞 bug
Collaborator
|
Could we add a test for this? Specifically for serialization and deserialization. Under the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure what happen in #560. I think I just copy paste the wrong code when rebasing but the serialize/deserialize just does not works.
I remplaced the JSON to a other text based string. The JSON format was too complex to deserialize the many custom types Godot offer. So the quick solution here is to use Godot built-in methods.
I know it's no more a JSON but it's still easy to read/edit
It's using the
var_to_strandstr_to_varbut does not allow Object to be parsed for security reasons. See issue#80562on Godot repo.