Open
Conversation
BenjaTK
added
✨ enhancement
Zehir
reviewed
Feb 18, 2026
|
|
||
| EditorInterface.get_file_system_dock().resource_removed.connect(_on_resource_removed) | ||
| EditorInterface.get_file_system_dock().file_removed.connect(_on_file_removed) | ||
|
|
Zehir
requested changes
Feb 18, 2026
Collaborator
Zehir
left a comment
Zehir
left a comment
There was a problem hiding this comment.
The graph_nodes directory is present twice;
res://addons/gaea/runtime/graph_nodes/graph_nodes/root/
In the file root_nodes_testing the NODES_PATH const should be res://addons/gaea/runtime/graph_nodes/root/
| @@ -1,7 +1,7 @@ | |||
| [gd_scene format=3 uid="uid://b2rceqo8rtr88"] | |||
Collaborator
There was a problem hiding this comment.
This scene should be in the editor directory instead
| extends EditorPlugin | ||
|
|
||
|
|
||
| func _enable_plugin() -> void: |
Collaborator
There was a problem hiding this comment.
I think you can remove all functions as they do nothing but keep the file
| @@ -0,0 +1,22 @@ | |||
| @tool | |||
Collaborator
There was a problem hiding this comment.
maybe rename the file to runtime-plugin.gd ?
|
|
||
|
|
||
| func _export_file(path: String, _type: String, _features: PackedStringArray) -> void: | ||
| if path.begins_with("res://addons/gaea/editor/"): |
Collaborator
There was a problem hiding this comment.
What if the directory is moved ? we could have some kind of path resolve
|
|
||
|
|
||
| func _export_file(path: String, _type: String, _features: PackedStringArray) -> void: | ||
| if path.begins_with("res://addons/gaea/editor/"): |
Collaborator
There was a problem hiding this comment.
You also need to exclude the file addons/gaea/gaea.gd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #521
This PR separates the plugin into
editorandruntimesub-plugins, making it more organized. It also adds a very simple export plugin which removes the wholeeditorsub-plugin from game exports. Exports don't work yet because of #573, but that's being worked on.