Conversation
Member
Author
|
I should really look at PRs before I start working on things... #42. |
Member
Author
|
@nuwang so I did this in a vacuum and only realized you'd already done it after I opened the PR and went to review what else was waiting. It turned out somewhat differently than your implementation, but I am fine with either, do you have an opinion? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cvmfspackage on EL depends on and forces the installation of Apache, it's not needed (as far as I can tell) on Stratum 1s since access is direct via the S3 URL. However, at least in my case I'll be proxying the S3 (Swift) URL (probably with nginx) since it's HTTPS on a non-standard port, which could be an issue for clients.