Skip to content

Don't rely on boolean coercion #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mvdbeek merged 2 commits into from
Nov 22, 2025
Merged

Don't rely on boolean coercion #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ad52c1
Don't rely on boolean coercion
mvdbeek Nov 22, 2025
b75c259
Fix boolean when: galaxy_additional_venv_packages
mvdbeek Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tasks/dependencies.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
environment:
PYTHONPATH: null
VIRTUAL_ENV: "{{ galaxy_venv_dir }}"
when: galaxy_additional_venv_packages
when: galaxy_additional_venv_packages | length > 0

remote_user: "{{ galaxy_remote_users.privsep | default(__galaxy_remote_user) }}"
become: "{{ true if galaxy_become_users.privsep is defined else __galaxy_become }}"
Expand Down
4 changes: 2 additions & 2 deletions tasks/paths.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
owner: "{{ __galaxy_privsep_user_name }}"
group: "{{ __galaxy_user_group }}" #This is set so that the galaxy_user can read the files in the priv_sep dirs. (As priv_sep dirs have defauly perms of 0640.)
mode: "{{ __galaxy_dir_perms }}"
loop: "{{ galaxy_privsep_dirs + galaxy_extra_privsep_dirs }}"
when: item | default(False)
# Skip null, xref https://github.com/galaxyproject/ansible-galaxy/pull/126
loop: "{{ (galaxy_privsep_dirs + galaxy_extra_privsep_dirs) | select | list }}"

- name: Create additional directories
file:
Expand Down
Loading