Open
Conversation
fail_on_error will allow ephemeris to be more easily integrated into CI/CD pipelines to automatically deploy new tool versions into Galaxy.
rhpvorderman
requested changes
Feb 15, 2021
Contributor
rhpvorderman
left a comment
rhpvorderman
left a comment
There was a problem hiding this comment.
It looks good to me. Can you add a test for this behavior?
|
|
||
| # Validate if all tools installed correctly | ||
| if args.fail_on_error and install_results and install_results.errored_repositories > 0: | ||
| log.info("The %s of a tool has failed. Exiting." % args.action) |
Contributor
There was a problem hiding this comment.
log.error would be more appropriate.
Alternatively: since log + exit is usted. It may be better to use raise an error instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves part of Tool testing improvements #117