Skip to content

Fixes to type annotations and test configurations#232

Open
nsoranzo wants to merge 5 commits intogalaxyproject:masterfrom
nsoranzo:fix_tox.ini
Open

Fixes to type annotations and test configurations#232
nsoranzo wants to merge 5 commits intogalaxyproject:masterfrom
nsoranzo:fix_tox.ini

Conversation

@nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Feb 4, 2026

Ping @lldelisle

@nsoranzo
Copy link
Member Author

nsoranzo commented Feb 4, 2026

The pytest failures are currently expected, will work on that next.

@lldelisle
Copy link
Contributor

Do we really need to lint on both python version?

@nsoranzo
Copy link
Member Author

nsoranzo commented Feb 4, 2026

Do we really need to lint on both python version?

IMO yes, it costs us 15s and it's not a change from the previous setup.

@lldelisle
Copy link
Contributor

Looks good to me but I am not sure to be the more competent person...

@nsoranzo
Copy link
Member Author

nsoranzo commented Feb 4, 2026

The pytest failures are currently expected, will work on that next.

I have a fix for this, will open a PR to galaxy's release_25.1 branch tomorrow, but this PR can be merged in the mean time.

@nsoranzo
Copy link
Member Author

nsoranzo commented Feb 5, 2026

The pytest failures are currently expected, will work on that next.

I have a fix for this, will open a PR to galaxy's release_25.1 branch tomorrow, but this PR can be merged in the mean time.

galaxyproject/galaxy#21753

@mvdbeek
Copy link
Member

mvdbeek commented Feb 11, 2026

just merge the galaxy pr, thank you!

@nsoranzo
Copy link
Member Author

I think we need updated 25.1 Galaxy packages for the tests to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants