Add CloudFront rewrites function, test, and deployment workflow#3390
Merged
natefoo merged 1 commit intogalaxyproject:masterfrom Oct 10, 2025
Merged
Add CloudFront rewrites function, test, and deployment workflow#3390natefoo merged 1 commit intogalaxyproject:masterfrom
natefoo merged 1 commit intogalaxyproject:masterfrom
Conversation
Member
Author
|
I don't really have a solution for this: location /events/gcc2021/training/ {
proxy_http_version 1.1;
proxy_set_header Host shiltemann.github.io;
proxy_pass https://shiltemann.github.io/gcc2021-training/;
}Other than to add a redirect for it. |
dannon
approved these changes
Oct 10, 2025
jplock
reviewed
Oct 10, 2025
| - name: Configure AWS Credentials | ||
| uses: aws-actions/configure-aws-credentials@v4 | ||
| with: | ||
| aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} |
There was a problem hiding this comment.
any chance you can update this to use GitHub OIDC instead of maintaining these long lived keys?
https://github.com/aws-actions/configure-aws-credentials?tab=readme-ov-file#oidc-configuration :)
Member
Author
There was a problem hiding this comment.
Well hey Justin, nice to see you here. 🤯 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hub is currently served via nginx on an EC2 instance proxying the Hub S3 bucket. I'm moving this to CloudFront but needed a way to implement the nginx-based rewrites, which is now done via this function. I only added a couple testing rewrites for now and will follow up with the full set if everything works.