Refactor of User-Reported Dataset Error Emails#19401
Refactor of User-Reported Dataset Error Emails#19401hujambo-dunia wants to merge 2 commits intogalaxyproject:devfrom
Conversation
|
Can you, please, reword the commit description as per our guidelines (https://github.com/galaxyproject/galaxy/blob/dev/CONTRIBUTING.md#how-to-contribute, item 6) - i.e., short imperative sentence, then space, followed by detailed description when needed). It really matters for working with git history and for release notes. |
d5c8c36 to
e86ee81
Compare
Make component reusable, changes made: * Componentized email web form into Vue.js * Decoupled the View (html email) from the Controller (API methods) * Abstracted the View elements for reuse with other objects (eg.Tools) * Utilized existing dependency (Python Jinja2) for repo consistency Reported by @hexylena in issue galaxyproject#17560 .
5363c23 to
922a3fa
Compare
|
Hey @hujambo-dunia ! Could you please rebase to resolve these conflicts? Additionally, seems like you've created a Update: If I locally refactor this, I reckon it'd make sense to restrict this to the backend change with the API abstraction, because the |
|
Bumping this to 26.1 for now. Happy to bring it back to 26.0 if it is still intended for that release and can be made merge ready. |
How to test the changes?
(Select all options that apply)
License