Vue3 Switch for Error/Warning Metrics?#21172
Draft
guerler wants to merge 1 commit intogalaxyproject:devfrom
Draft
Vue3 Switch for Error/Warning Metrics?#21172guerler wants to merge 1 commit intogalaxyproject:devfrom
guerler wants to merge 1 commit intogalaxyproject:devfrom
Conversation
Member
|
@guerler All of the build errors were fixed in that branch fairly recently. I will rebase again, remember the sticking point was the forced jest test migration due to vue-test-utils incompatibility. Before we spend more time redoing work that is already done, lets' dicsuss in the weekly call? |
d676f31 to
0e3ffbc
Compare
0e3ffbc to
20e31f8
Compare
Contributor
Author
with latest dev at: 426fcd1 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches to
@vue/compatto see how many errors and warnings we get (heads up...quite a few 😅). The idea is to have a baseline so we can start picking off issues in small PRs. These PRs against dev could be merged immediately since they wouldn’t include thecompatswitch.The main goal is to speed up merging #20787 by breaking it into smaller chunks. This strategy could reduce conflicts with other PRs and the risk of stale branches. People can check out this branch, fix errors/warnings in small PRs against dev, and then we rebase this
compatbranch weekly. That way we can track progress. I will also try to categorize the errors and warnings to make it easier to pick issues. Some errors might need to wait until we fully switch to Vue 3, but many should be fixable in dev even without Vue 3.How to test the changes?
(Select all options that apply)
License