[25.1] Fix Docker build issues for k8s_ci container #21593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes Galaxy's lib/ modules (galaxy, galaxy_ext, tool_shed, etc.) importable without requiring the full Galaxy startup.
The pattern `node_modules` only matches at the root level in .dockerignore (unlike .gitignore). Use `**/node_modules` to exclude client/node_modules and avoid copying 22GB to the build context.
The ansible role passes requirement lines directly to pip as CLI arguments. Newer pip versions reject inline comments like `# type: webdav`. Strip these before running the playbook.
mvdbeek
reviewed
Jan 20, 2026
| COPY . $SERVER_DIR/ | ||
|
|
||
| # Strip inline comments from conditional-requirements.txt (ansible role passes lines directly to pip) | ||
| RUN sed -i 's/[[:space:]]*# type:.*$//' $SERVER_DIR/lib/galaxy/dependencies/conditional-requirements.txt |
Member
There was a problem hiding this comment.
I'd imagine this would also be an issue for ansible-galaxy ?
Member
There was a problem hiding this comment.
mvdbeek
reviewed
Jan 20, 2026
|
|
||
| ENV PATH="$SERVER_DIR/.venv/bin:${PATH}" | ||
| ENV GALAXY_CONFIG_CONDA_AUTO_INIT=False | ||
| ENV PYTHONPATH="$SERVER_DIR/lib/" |
Member
There was a problem hiding this comment.
Does that not mess with the tool execution environment ? it may be fine but may also be a gotcha later on
Member
Author
There was a problem hiding this comment.
Would love a sanity check from other deployments of the container -- this fixed problems I had but I can maintain it as a patch if need be.
mvdbeek
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
# type:comments from conditional-requirements.txt before ansible runs (newer pip rejects them as CLI args)How to test the changes?
(Select all options that apply)
License