[WIP] Replace BModal usage with GModal in several components#22114
Draft
ahmedhamidawan wants to merge 19 commits intogalaxyproject:devfrom
Draft
[WIP] Replace BModal usage with GModal in several components#22114ahmedhamidawan wants to merge 19 commits intogalaxyproject:devfrom
ahmedhamidawan wants to merge 19 commits intogalaxyproject:devfrom
Conversation
ahmedhamidawan
added
kind/enhancement
area/UI-UX
kind/refactoring
ahmedhamidawan
force-pushed
the
b_modal_to_g_modal_simpler_components
branch
from
725a08e to
4467d60
Compare
Tests cover: - WorkflowCardList: shows WorkflowRename with correct props on rename event, does not retain stale name when opening rename for a different workflow - WorkflowRename: calls updateWorkflow with new name and emits close on confirm, shows toast error and preserves original name on reopen after failure, keeps ok button disabled when name is unchanged
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to test the changes?
(Select all options that apply)
License