Show step/tool form for currently active step in invocation view by ahmedhamidawan · Pull Request #22144 · galaxyproject/galaxy

ahmedhamidawan · 2026-03-17T01:18:51Z

When viewing an active step in the invocation graph, tool steps that have a job associated with them now show a "Tool Form" toggle button in the step card header.
Clicking it replaces the job summary with the full ToolForm pre-populated from the job's original inputs via job_id, giving users a clear view of exactly what parameters were used when the step ran — without having to navigate back to the workflow editor.

toggle_step_display_in_invocation_view_TOOL_FORM.mp4

Fixes #21086

How to test the changes?

(Select all options that apply)

I've included appropriate automated tests.
This is a refactoring of components with existing test coverage.
Instructions for manual testing are as follows:
1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

mvdbeek · 2026-03-17T08:51:36Z

Clicking it replaces the job summary with the full ToolForm pre-populated from the job's original inputs via job_id, giving users a clear view of exactly what parameters were used when the step ran

This is pretty cool, maybe call it "Rerun Job" though ? We don't really refer to tool form anywhere in the interface ?
Is the code actually included in the PR ? (A separate PR might be better)

Fixes #21086

On the expanded current active step below, add a toggle to show the step form (I guess just like it shows up in the workflow editor when you click on a step). This is mainly helpful when a step has no jobs currently; we can show this instead of nothing below. Also, users will often have to go back into the editor to see a step's configuration so this will prevent them from having to do that, just show it in the same view below.

That's still missing to close #21086, i think ?

ahmedhamidawan · 2026-03-17T13:14:59Z

Is the code actually included in the PR ?

Sorry, I forgot to push the actual commits last night. Pushed them now.

(A separate PR might be better)

And then I read this 🤦 . You're right, I'll pull the second change into a separate PR

That's still missing to close 21086, i think ?

Well, isn't this tool form being rendered below basically what we wanted there?

mvdbeek · 2026-03-17T13:19:30Z

This is mainly helpful when a step has no jobs currently;

…eters When viewing an active step in the invocation graph, tool steps that have a job associated with them now show a "Tool Form" toggle button in the step card header. Clicking it replaces the job summary with the full ToolForm pre-populated from the job's original inputs via job_id, giving users a clear view of exactly what parameters were used when the step ran — without having to navigate back to the workflow editor. The toggle is only shown when the invocation's history is the current active history. This is required because ToolForm needs access to the history's datasets to correctly populate data input fields; showing it against a non-current history would result in mismatched or unavailable dataset references. The form resets to hidden whenever the active step changes, so each step starts from a clean state.

…acking

We would still potentially have a `tool_id` at the step, so it makes sense to render that.

ahmedhamidawan · 2026-03-17T19:56:21Z

I've made it so that we still render the step's form, even if there is no job id for the step (there is still possible a tool id to render the form).

mvdbeek · 2026-03-18T07:34:30Z

client/src/components/Workflow/Invocation/Graph/InvocationGraph.vue

+                        class="invocation-tool-form pt-2"
+                        :job_id="viewableJobId"
+                        :history_id="props.invocation.history_id" />
+                    <BAlert v-else show>No job information available for this step.</BAlert>


If you wanted to close the issue you've referenced you'd want to render a read only version of the step config

mvdbeek · 2026-03-18T07:38:24Z

client/src/components/Workflow/Invocation/Graph/InvocationGraph.vue

+                                showToolForm
+                                    ? 'Hide step form'
+                                    : viewableJobId
+                                      ? 'View exact run parameters and rerun this step'


That is so long and why would you say "exact" ? Noone thought this was not going to be exact until you said it 😆

Also noone knows what a step form or tool form is. Even reading the code I wouldn't know what showToolForm means since we have so many variants of it.

Suggested change

? 'View exact run parameters and rerun this step'

? 'Rerun this job'

we don't even have a way to rerun a step, that's a different thing.

mvdbeek · 2026-03-18T07:39:46Z

client/src/components/Workflow/Invocation/Graph/InvocationGraph.vue

                            </GButton>
                        </GButtonGroup>
+                        <GButton
+                            v-if="viewableToolId"


You can render non-tool step configs. I'd split this up into show step config and rerun job. Which are similar but distinct things.

So, would it make sense to have an additional Rerun Job button in the same header (which exists if a job id exists) and clicking it opens the job rerun view (with the tool form)?

And then otherwise, we keep this button, which says Show Step Config and it displays the step config below; with the step config being exactly what you see in the editor.

So, would it make sense to have an additional Rerun Job button in the same header (which exists if a job id exists) and clicking it opens the job rerun view (with the tool form)?

Would that not be better served in the job list ? I could go either way for the rerun.

The step config is really what I'd want to see, it also includes PJAs, labels etc

Yeah, I think let's just render the step form for every step (except inputs and maybe subworkflows?)

dannon

Nice idea — being able to see step config without bouncing back to the editor is a clear win.

Agreeing with mvdbeek's direction here: the step config view (what you see in the editor — parameters, PJAs, labels) is the thing to show. The full ToolForm is an execution form, so using it as a "view parameters" display risks users accidentally rerunning jobs. Splitting "view config" from "rerun" is the right call.

A couple of small things I noticed in the current diff:

The v-else BAlert at line 341 ("No job information available") is unreachable — showToolForm can only be true when viewableToolId is truthy (the button is guarded by v-if="viewableToolId"), so the v-else-if always wins.
The activeCardHeaderClass computed + z-index overrides (.tool-header, .multiselect__content-wrapper) are fighting ToolForm's internal layout. If you switch to a read-only step config view this should go away naturally.

ahmedhamidawan · 2026-03-18T16:25:24Z

thank you @dannon, those are great points, I'll fix those things. Yes, a readonly step config is exactly what we need.

ahmedhamidawan added this to the 26.1 milestone Mar 17, 2026

ahmedhamidawan added area/UI-UX kind/feature labels Mar 17, 2026

ahmedhamidawan changed the title ~~Allow toggling between detailed (editor like) invocation view steps~~ Show step/tool form for currently active step in invocation view Mar 17, 2026

ahmedhamidawan added 3 commits March 17, 2026 14:32

prevent tool form sticky header from covering multiselects

c1f3d40

make step header sticky, disabled when tool form is shown to avoid st…

dadb723

…acking

ahmedhamidawan force-pushed the toggle_step_display_in_invocation_view branch from c030ca3 to dadb723 Compare March 17, 2026 19:35

even if a job id is not available for the step, still render the form

f199bdc

We would still potentially have a `tool_id` at the step, so it makes sense to render that.

ahmedhamidawan marked this pull request as ready for review March 17, 2026 21:18

mvdbeek reviewed Mar 18, 2026

View reviewed changes

dannon reviewed Mar 18, 2026

View reviewed changes

ahmedhamidawan marked this pull request as draft March 18, 2026 22:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show step/tool form for currently active step in invocation view#22144

Show step/tool form for currently active step in invocation view#22144
ahmedhamidawan wants to merge 4 commits intogalaxyproject:devfrom
ahmedhamidawan:toggle_step_display_in_invocation_view

ahmedhamidawan commented Mar 17, 2026 •

edited

Loading

Uh oh!

mvdbeek commented Mar 17, 2026 •

edited

Loading

Uh oh!

ahmedhamidawan commented Mar 17, 2026

Uh oh!

mvdbeek commented Mar 17, 2026

Uh oh!

ahmedhamidawan commented Mar 17, 2026

Uh oh!

mvdbeek Mar 18, 2026

Uh oh!

mvdbeek Mar 18, 2026 •

edited

Loading

Uh oh!

mvdbeek Mar 18, 2026

Uh oh!

ahmedhamidawan Mar 18, 2026

Uh oh!

mvdbeek Mar 18, 2026

Uh oh!

ahmedhamidawan Mar 18, 2026 •

edited

Loading

Uh oh!

dannon left a comment

Uh oh!

ahmedhamidawan commented Mar 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	? 'View exact run parameters and rerun this step'
	? 'Rerun this job'

Conversation

ahmedhamidawan commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to test the changes?

License

Uh oh!

mvdbeek commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahmedhamidawan commented Mar 17, 2026

Uh oh!

mvdbeek commented Mar 17, 2026

Uh oh!

ahmedhamidawan commented Mar 17, 2026

Uh oh!

mvdbeek Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

mvdbeek Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mvdbeek Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

ahmedhamidawan Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

mvdbeek Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

ahmedhamidawan Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dannon left a comment

Choose a reason for hiding this comment

Uh oh!

ahmedhamidawan commented Mar 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ahmedhamidawan commented Mar 17, 2026 •

edited

Loading

mvdbeek commented Mar 17, 2026 •

edited

Loading

mvdbeek Mar 18, 2026 •

edited

Loading

ahmedhamidawan Mar 18, 2026 •

edited

Loading