[26.0] Fix oauth2 template validation

[davelopez]

Alternative to #22151 discussed in #22246 (comment)

Fixes #22041

The users now see:

And the logged error is:

Traceback (most recent call last):
  File "/home/dlopez/dev/gx-version/26.0/lib/galaxy/managers/file_source_instances.py", line 649, in template_server_configuration
    environment = prepare_environment_from_root(template.environment, self._app_vault, self._app_config)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dlopez/dev/gx-version/26.0/lib/galaxy/managers/_config_templates.py", line 293, in prepare_environment_from_root
    raise ConfigurationError(
galaxy.exceptions.ConfigurationError: Environment variable GALAXY_GOOGLE_DRIVE_APP_CLIENT_ID not found for environment entry oauth2_client_id and no default provided. This variable is required to be set in the environment for the template to function. Please set this variable in the environment or provide a default value in the template definition.

and for secrets, a similar exception:

galaxy.exceptions.ConfigurationError: Secret vault key file_source_secrets/google_drive/app_client_id not found for environment entry oauth2_client_id and no default provided. This secret is required to be set in the vault for the template to function. Please set this secret in the vault or provide a default value in the template definition.

How to test the changes?

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[davelopez]

@mvdbeek is this more in line with what you expect?

[mvdbeek]

No, sorry. The environment variable is set, there's just nothing under the actual vault key.

Sorry, I saw Environment variable GALAXY_GOOGLE_DRIVE_APP_CLIENT_ID not found for environment entry oauth2_client_id first. It's closer

[mvdbeek]

IOW this is a misleading message. I'm fine to call it wontfix, but we shouldn't say it's not in the environment variables when in fact it is.

[mvdbeek]

You could just let the exception bubble out, InternalServerError is a MessageException subclass, IIRC it's also logged

[davelopez]

If I let the exception bubble out, the message shown to the user will be:

Looks rather internal and confusing to the user, which is why I wrapped it.

[mvdbeek]

Awesome, thank you so much, I think that results in clear error messages!

[dannon]

@davelopez Thank you for taking a look at this, looks great to me!