Add a patch job for making the NFS service LoadBalancer type#94
Open
Add a patch job for making the NFS service LoadBalancer type#94
Conversation
nuwang
approved these changes
Aug 1, 2025
Member
nuwang
left a comment
nuwang
left a comment
There was a problem hiding this comment.
I think copying the service manifest from ganesha would be a much simpler approach. This not only has a non-trivial amount of code, it's also slower since there's now an extra init container etc. In contrast, if we just copy the yaml service manifest off Ganesha and delete the unnecessary ports - the only complicated part would be making sure the pod label selectors match the release-name - which we also do elsewhere so no big deal?
nuwang
requested changes
Aug 1, 2025
Member
nuwang
left a comment
nuwang
left a comment
There was a problem hiding this comment.
Sorry, I meant to just comment.
Collaborator
|
It think if we restrict ourselves to NFSv4 we only need TCP. UDP is (was) only needed in NFSv3 for the portmapper service. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCP LoadBalancers (LB) cannot have a mix of protocol types, which is all NFS Ganesha chart supports. This patch job changes the ports exposed by the NFS Service manifest to use only TCP and switches the service type to (an internal) LB. This is all so a GCP Batch job can mount Galaxy's NFS.