Skip to content

Remove duplicate /pag-2026 entry#113

Merged
jdavcs merged 2 commits intomainfrom
fix-duplicate-pag-2026
Mar 4, 2026
Merged

Remove duplicate /pag-2026 entry#113
jdavcs merged 2 commits intomainfrom
fix-duplicate-pag-2026

Conversation

@dannon
Copy link
Member

@dannon dannon commented Jan 28, 2026

Summary

  • Removes duplicate /pag-2026 entry that was causing test failures
  • The entry existed in two places with different destinations; consolidated to just the PAG 2026 section

@github-actions
Copy link

.............................................................................................................................
125 tests, 0 failures.

@dannon dannon requested a review from jdavcs January 29, 2026 13:03
natefoo
natefoo previously approved these changes Feb 26, 2026
jdavcs
jdavcs previously approved these changes Mar 4, 2026
There were two entries for /pag-2026 - one in the conferences section and one
in the PAG 2026 section. Consolidated to just the PAG 2026 section with the
correct destination pointing to /pag33/.
@dannon dannon dismissed stale reviews from jdavcs and natefoo via cbff353 March 4, 2026 14:33
@dannon dannon force-pushed the fix-duplicate-pag-2026 branch from a4559e9 to cbff353 Compare March 4, 2026 14:33
@github-actions
Copy link

github-actions bot commented Mar 4, 2026

..................................................................................................................................
130 tests, 0 failures.

Copy link
Member

@jdavcs jdavcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is right after all: the PR that introduced the bug (#109) intended to "Point at the whole infographic site so people can find all the links" - so the link should be to https://nekrut.github.io/infographics/, without the pag33 suffix.

@dannon
Copy link
Member Author

dannon commented Mar 4, 2026

If we want to add an /infographics/ link that'd be great, but the pag33 permalink intent has to be to point to the pag33 infographics?

@github-actions
Copy link

github-actions bot commented Mar 4, 2026

...................................................................................................................................
131 tests, 0 failures.

@jdavcs
Copy link
Member

jdavcs commented Mar 4, 2026

Actually, I've just noticed, that page has 4 infographics - and the links to the other three are right there - https://github.com/galaxyproject/gxy.io/blob/main/group_vars/all.yaml#L45

@jdavcs jdavcs merged commit fb8ebc2 into main Mar 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants