Mobile filter improvements and code cleanup#1061
Closed
dannon wants to merge 5 commits intogalaxyproject:mainfrom
Closed
Mobile filter improvements and code cleanup#1061dannon wants to merge 5 commits intogalaxyproject:mainfrom
dannon wants to merge 5 commits intogalaxyproject:mainfrom
Conversation
Configure playwright with separate desktop and mobile projects so tests run at both viewport sizes. Add mobile-specific filter tests that verify the filter button visibility and functionality on small screens.
MobileFilterSheet component shows a filter button on mobile that opens a bottom sheet with the category list. Uses same store and URL patterns as the desktop sidebar.
Fixes eslint no-require-imports error in the TypeScript config file.
The FilterSidebar and MobileFilterSheet components had a lot of duplicated filter state management code. This pulls that out into a shared composable, cutting down on repetition and making both components simpler to follow.
Member
Author
|
Forgot about this and just wrapped up some work that's going to conflict. Going to close this and merge it into that branch to just do it all at once. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan