Skip to content

Conversation

@Ang-dot
Copy link
Contributor

@Ang-dot Ang-dot commented Mar 24, 2025

Summary

Enhance game-twitter-plugin server auth shutdown mechanism.

Changes

  • move self.server.shutdown() to another thread to avoid server hang.
  • standardize log output with GAME Node SDK.

Dev Testing

@Ang-dot Ang-dot requested a review from celesteanglm March 24, 2025 12:58
@github-actions github-actions bot added enhancement New feature or request plugin Plugin contribution labels Mar 24, 2025
@Ang-dot Ang-dot self-assigned this Mar 24, 2025
@celesteanglm
Copy link
Contributor

nice catch!

@celesteanglm celesteanglm merged commit 478350d into main Mar 24, 2025
6 checks passed
@celesteanglm celesteanglm deleted the plugin/yang-game-twitter-auth-enhancement branch March 24, 2025 19:54
MichielMAnalytics pushed a commit to MichielMAnalytics/game-python that referenced this pull request Jun 12, 2025
…yang-game-twitter-auth-enhancement

[Plugin] Enhance Game Twitter Plugin Auth Server Shutdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request plugin Plugin contribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants