Skip to content

Conversation

@Ang-dot
Copy link
Contributor

@Ang-dot Ang-dot commented Mar 6, 2025

Summary

Trigger automated CI validation for new plugin's metadata.

Changes

  • Notion
  • Added extra checkboxes for .github/PULL_REQUEST_TEMPLATE/plugin.md
  • Added GH workflow to automate check for plugin_metadata.yml, will only trigger for new plugins folder, this check shall not affect existing plugin folders.

Related Changes

Description PR
[Part 1] [Chore] Add PR Templates #80
[Part 2] [CI] Add Validation to New Plugin's Metadata ⬅️

Dev Testing

Tested with #92 Mock PR.

@Ang-dot Ang-dot requested a review from celesteanglm March 6, 2025 11:03
@Ang-dot Ang-dot self-assigned this Mar 6, 2025
@github-actions github-actions bot added the plugin Plugin contribution label Mar 6, 2025
@Ang-dot Ang-dot requested a review from jxx016 March 13, 2025 04:56
Copy link
Contributor

@jxx016 jxx016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approved!

Just a quick question:
Do we need detailed_description as required field too? Just curious about your thoughts, because their readme should have more explanation and it feels like a quick description should be sufficient.

@Ang-dot
Copy link
Contributor Author

Ang-dot commented Mar 14, 2025

Looks good! Approved!

Just a quick question: Do we need detailed_description as required field too? Just curious about your thoughts, because their readme should have more explanation and it feels like a quick description should be sufficient.

Hey John, thanks for the review, your point is valid, as long as we required a good readme, it should do it for the detailed description, however, I'm thinking that since the workflow is implemented for us/marketing to refer to as the official docs, it's good to have a single point of reference for all plugin details without checking both readme and plugin_metadata.yml in different places ^

@jxx016 jxx016 merged commit 55ea1d7 into main Mar 17, 2025
6 checks passed
MichielMAnalytics pushed a commit to MichielMAnalytics/game-python that referenced this pull request Jun 12, 2025
…validate-plugin-metadata

[CI] Add Validation to New Plugin's Metadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin Plugin contribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants