-
-
Notifications
You must be signed in to change notification settings - Fork 83
output buildId #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
output buildId #89
Conversation
WalkthroughThe pull request adds BuildID capture functionality to a Steam deployment GitHub Action. It introduces output logging for the build upload command, extracts the BuildID from logs, and exports it as an action output alongside the manifest path. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a new buildId output to the Steam Deploy GitHub Action, which captures the Steam BuildID from the upload process. This enables workflows to reference the specific build ID for downstream operations like notifications, tracking, or additional automation steps.
Key Changes
- Captures steamcmd output to a log file using
teefor post-processing - Extracts the BuildID using grep with a Perl-compatible regex pattern
- Exposes buildId as a GitHub Action output alongside the existing manifest output
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| steam_deploy.sh | Pipes steamcmd output through tee to capture logs, extracts BuildID using grep pattern, and outputs buildId to GITHUB_OUTPUT |
| action.yml | Adds buildId output definition with description |
| .gitignore | Excludes build_output.log from version control |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| buildId=$(grep -oP '\(BuildID \K\d+(?=\))' build_output.log || echo "") | ||
|
|
||
| echo "manifest=${manifest_path}" >> $GITHUB_OUTPUT | ||
| echo "buildId=${buildId}" >> $GITHUB_OUTPUT |
Copilot
AI
Dec 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new buildId output lacks test coverage. The existing workflow in .github/workflows/main.yml should be updated to verify that the buildId output is correctly captured and set.
Consider adding a step after the steam-deploy action to check the output:
- id: deploy
uses: ./
with:
# existing configuration
- run: |
echo "Build ID: ${{ steps.deploy.outputs.buildId }}"
if [ -z "${{ steps.deploy.outputs.buildId }}" ]; then
echo "Warning: buildId output is empty"
fi| buildId: | ||
| description: "The Steam BuildID of the uploaded build" |
Copilot
AI
Dec 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new buildId output is not documented in the README. Users should be informed about this new output and how to use it.
Consider adding a section in the README that documents the outputs available from this action, including both manifest and buildId. For example:
## Outputs
#### buildId
The Steam BuildID of the uploaded build. This can be used to reference the specific build in subsequent steps or for tracking purposes.
#### manifest
The path to the generated manifest.vdf file.|
@copilot open a new pull request to apply changes based on the comments in this thread |
Changes
buildIdthat can be used for other things.Checklist
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.