Adds support for .upmconfig.toml in Windows Docker images#705
Adds support for .upmconfig.toml in Windows Docker images#705davidmfinol merged 14 commits intogame-ci:mainfrom
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (3)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the 📝 WalkthroughWalkthroughThe update modifies the Windows Docker command generation logic to add a volume mount for a Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@lupidan Can you pull from main and rebuild to update this PR? |
# Conflicts: # dist/index.js # dist/index.js.map
After `yarn` + `npm run build`
|
@davidmfinol Sorry about that, I finally found some time to update my PR branch. 🙌 I merged the latest main branch and I did re-run: The licenses.txt file seemed to be missing some information too, so I did commit it, to keep updated. (Doesn't seem to be something related to the code I just added) |
# Conflicts: # dist/index.js.map
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #705 +/- ##
==========================================
- Coverage 37.07% 37.05% -0.03%
==========================================
Files 77 77
Lines 3161 3163 +2
Branches 625 626 +1
==========================================
Hits 1172 1172
- Misses 1989 1991 +2
🚀 New features to boost your workflow:
|
|
Released in v4.6.0 |

Changes
_github_homefolder in the runner's temp folder if it does not exist._github_homefrom thetempfolder intoC:\githubhome, to align with the current documentation that works on macoOS and ubuntu.entrypoint.ps1to check if a.upmconfig.tomlis available inC:\githubhome, and copies it into current user's home folder, so Unity can see it.Checklist
code of conduct
Summary by CodeRabbit
C:/githubhomeinside the container.