Skip to content

Added install_llvmpipe script to replace -nographics in Windows builds #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webbertakken merged 12 commits into from
May 17, 2025
Merged

Added install_llvmpipe script to replace -nographics in Windows builds #706

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
35d92b3
Added install_llvmpipe script
DoctorGester May 6, 2025
b418dc6
Replace ternary with a regular condition
DoctorGester May 6, 2025
109ee86
Revert files I haven't changed
DoctorGester May 6, 2025
439bc78
Pin llvmpipe version, expand test matrix with a single enableGPU target
DoctorGester May 17, 2025
7b5eadc
Fixed parameter name
DoctorGester May 17, 2025
6c9a7e4
EnableGPU false by default
DoctorGester May 17, 2025
843ec80
Fixed nitpick
DoctorGester May 17, 2025
0535838
Fixed scripts
DoctorGester May 17, 2025
41502ff
Pass enableGpu into tests properly
DoctorGester May 17, 2025
657c729
Fixed script
DoctorGester May 17, 2025
f63df5a
Append With GPU to build name
DoctorGester May 17, 2025
cf13c59
Fix expression
DoctorGester May 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/build-tests-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,12 @@ jobs:
- StandaloneWindows64 # Build a Windows 64-bit standalone.
- WSAPlayer # Build a UWP App
- tvOS # Build an Apple TV XCode project
include:
# Additionally test enableGPU build for a standalone windows target
- projectPath: test-project
unityVersion: 2023.2.2f1
targetPlatform: StandaloneWindows64
enableGpu: true
Comment on lines +29 to +36
Copy link

@coderabbitai coderabbitai bot May 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Verify custom action supports enableGpu input and applies -force-opengl
Ensure that the local Unity build action (referenced via uses: ./) defines an enableGpu input and, when true, replaces -nographics with -force-opengl in its invocation.

🏁 Script executed:

#!/bin/bash
# Description: Confirm that the custom GameCI action recognizes `enableGpu` and uses it to set `-force-opengl`.
# 1. Search action metadata & implementation for enableGpu
rg 'enableGpu' -n .
# 2. Search for force-opengl flag usage
rg 'force-opengl' -n .

Length of output: 66784

enableGpu flag not applied in Unity CLI invocation
The custom action defines the enableGpu input (see action.yml:42), but there’s no code handling it to swap out the default -nographics flag for -force-opengl. You’ll need to update the Unity command builder so that when buildParameters.enableGpu is true it:

  • removes or omits the -nographics argument
  • adds the -force-opengl argument

And add or extend tests (e.g. in src/model/input.test.ts) to verify that the CLI args include -force-opengl only when enableGpu is true.

🤖 Prompt for AI Agents 
In .github/workflows/build-tests-windows.yml around lines 29 to 34, the
enableGpu flag is set but the Unity CLI invocation does not handle it to replace
the default -nographics flag with -force-opengl. To fix this, update the Unity
command builder code to check if buildParameters.enableGpu is true; if so,
remove or omit the -nographics argument and add the -force-opengl argument
instead. Additionally, extend or add tests, such as in src/model/input.test.ts,
to verify that the CLI arguments include -force-opengl only when enableGpu is
true.


steps:
###########################
Expand Down
Loading