Improve Par_EquilibriumIC#315
Conversation
…_ParEqmIC and Par_Init_ByFunction_ParEqmIC
|
I have updated it to the latest main branch and resolved the conflicts. |
koarakawaii
left a comment
There was a problem hiding this comment.
Temporarily review break point.
|
Updated to the latest main branch. |
Conflicts: src/Particle/Par_EquilibriumIC.cpp
...e/test_problem/Hydro/ParticleEquilibriumIC/plot_script/plot_ParEquilibriumIC_Distribution.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Hsinhao Huang <hsinaohuang@gmail.com>
There was a problem hiding this comment.
@hsinhaoHHuang This PR is neat. Thanks for the excellent contributions! I only have minor comments and will proceed with merge once they are addressed.
In addition to the inline comments, please also take care of the following tasks:
- Update the wiki to provide instructions on how to use this initial condition constructor
- Add
Record__ParEquilibriumIC_Model_*toexample/test_problem/Hydro/ParticleEquilibriumIC/clean.sh
example/test_problem/Hydro/ParticleEquilibriumIC/plot_profile/plot_eureka.job
Outdated
Show resolved
Hide resolved
...e/test_problem/Hydro/ParticleEquilibriumIC/plot_script/plot_ParEquilibriumIC_Distribution.py
Outdated
Show resolved
Hide resolved
src/TestProblem/Hydro/ParticleEquilibriumIC/Init_TestProb_Hydro_ParEqmIC.cpp
Outdated
Show resolved
Hide resolved
example/test_problem/Hydro/ParticleEquilibriumIC/Input__ParEqmIC_Double2
Outdated
Show resolved
Hide resolved
example/test_problem/Hydro/ParticleEquilibriumIC/Input__ParEqmIC_Single
Outdated
Show resolved
Hide resolved
src/TestProblem/Hydro/ParticleEquilibriumIC/Init_TestProb_Hydro_ParEqmIC.cpp
Outdated
Show resolved
Hide resolved
src/TestProblem/Hydro/ParticleEquilibriumIC/Init_TestProb_Hydro_ParEqmIC.cpp
Outdated
Show resolved
Hide resolved
src/TestProblem/Hydro/ParticleEquilibriumIC/Init_TestProb_Hydro_ParEqmIC.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
@hsinhaoHHuang This PR is neat. Thanks for the excellent contributions! I only have minor comments and will proceed with merge once they are addressed.
In addition to the inline comments, please also take care of the following tasks:
- Update the wiki to provide instructions on how to use this initial condition constructor
- Add
Record__ParEquilibriumIC_Model_*toexample/test_problem/Hydro/ParticleEquilibriumIC/clean.sh
Co-authored-by: Hsi-Yu Schive <hyschive@gmail.com>
Co-authored-by: Hsi-Yu Schive <hyschive@gmail.com>
|
@hyschive I have updated this PR according to the comments, including adding sanity checks for the order of function calls and adding instructions to the wiki.
Please have another look when you have time and let me know whether there is anything that needs further modifications. |
hyschive
left a comment
There was a problem hiding this comment.
@hsinhaoHHuang Looks good. I only have a few minor comments before merging. Please also check this comment.
Co-authored-by: Hsi-Yu Schive <hyschive@gmail.com>
|
I have updated the PR according to the comments. |
Goal
convertToString().c_str()inPar_EquilibriumIC.cpp#201Changes
Adjust the user interface
TestProblem/Hydro/ParticleEquilibriumIC/Init_TestProb_Hydro_ParEqmIC.cpplike other test problems.setXXX()as the interface to set the parameters for the cloud constructors from test problems, and only the necessary parameters are needed to be set.Adjust the calculation
Adjust the format
Verification Tests
Compare the distribution to the analytical solutions. -> The results can match analytical solutions.
Check the stability of a single NFW profile with the default setup. -> The results are stable.