Conversation
|
@xuanweishan Before reviewing the PR, I noticed that the filenames in the workflow file ( |
|
Those two files are updated. |
|
@xuanweishan please also fix the following links. Also, how about renaming the files under |
|
@ChunYen-Chen I've rename files in |
ChunYen-Chen
left a comment
There was a problem hiding this comment.
@xuanweishan Thanks for the contribution. I have left some comments. Please update the lines with comment tags [Bug] or [Style].
[Bug]: Some of the [[[xxx] yyy | page-link]] does not render the correct hypre link "[xxx] yyy" (currently "[xxx] yyy" ). By changing the text to [[ [xxx] yyy | page-link ]], the link can be shown correctly.
Our current wiki pages have an issue. [Runtime-Parameters]—All.md takes too long to render, so the page does not show on GitHub. (@hyschive)
|
@ChunYen-Chen Thanks for the suggestions, I've apply suggestions above. |
ChunYen-Chen
left a comment
There was a problem hiding this comment.
@xuanweishan Thanks for the update. I have left some final comments.
|
The suggestions above are applied. Please check. |
|
@ChunYen-Chen The bug is fixed. Thanks for the carefully checking. |
ChunYen-Chen
left a comment
There was a problem hiding this comment.
@xuanweishan Thanks for the update.
@hyschive I think this PR is ready to go.
…-related|Quick-Start_related}/
…[Runtime-Parameter]-MemoryPool.md
3a1fb0d to
e091348
Compare
hyschive
left a comment
There was a problem hiding this comment.
@xuanweishan @ChunYen-Chen Thanks for your contributions and the detailed review!
Description
This PR solved the issue #325.
To support different OS file system, we rename the file names with
:and*.Changes
:with[ ], and replace*with{}in file names.doc/wiki/Installation-related/Installation:*=>
doc/wiki/Installation-related/[Installation]*doc/wiki/In-Situ-Python-Analysis-related/In-Situ-Python-Analysis:*=>
doc/wiki/In-Situ-Python-Analysis-related/[In-Situ-Python-Analysis]*doc/wiki/Contribute-related/Contribute:*=>
doc/wiki/Contribute-related/[Contribute]*doc/wiki/Performance-Optimizations-related/Performance-Optimizations:*=>
doc/wiki/Performance-Optimizations-related/[Performance-Optimizations]*doc/wiki/Quick-Start-related/Quick-Start:*=>
doc/wiki/Quick-Start-related/[Quick-Start]*doc/wiki/Runtime-Parameters-related/Runtime-Parameters:*=>
doc/wiki/Runtime-Parameters-related/[Runtime-Parameters]*doc/wiki/Runtime-Parameters:-Input__Flag_*.md=>
doc/wiki/[Runtime-Parameters]-Input__Flag_{}.mddoc/wiki/Simulation-Logs-related/Simulation-Logs:*=>
doc/wiki/Simulation-Logs-related/[Simulation-Logs]*doc/wiki/Simulation-Logs:-Record__TimingMPI_Rank*.md=>
doc/wiki/[Simulation-Logs]-Record__TimingMPI_Rank{}.md